fix: add sender-aware borrow owner-index lookup and harden route tests#153
Merged
bayological merged 4 commits intomainfrom Mar 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes borrow owner-index selection sender-aware so opening a trove uses the first unused derived trove id instead of assuming the current Trove NFT balance is always a safe next index. It also avoids unnecessary trove scans for owners with no Trove NFT balance and clarifies zombie trove and Trove NFT ownership behavior in the borrow docs.
It also hardens the Monad and router integration tests by selecting quoteable routes dynamically instead of relying on discovered routes that may not be quoteable on-chain at test time.
Other changes
3.2.0getOwnedTroveCount()andfindNextAvailableOwnerIndex()getNextOwnerIndex()as a compatibility alias for current owned trove countTested
Related issues
Backwards compatibility
This change is backwards compatible.
getNextOwnerIndex()remains available, but consumers opening new troves should preferfindNextAvailableOwnerIndex()because trove ids depend on both the owner and the transaction sender.Documentation
README.mdCHANGELOG.md