Merged
Conversation
Andrew718PLTS
requested changes
Oct 2, 2025
Contributor
Andrew718PLTS
left a comment
Andrew718PLTS
left a comment
There was a problem hiding this comment.
Code review: Left some different comments.
Testing: LGTM.
...to make interfaces more ergonomic for our UIs to consume
Andrew718PLTS
approved these changes
Oct 7, 2025
Contributor
Andrew718PLTS
left a comment
Andrew718PLTS
left a comment
There was a problem hiding this comment.
LGTM, there's only one comment remaining.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding
getTokensin #86 was good, but it wasasyncwhich made using it in UIs cumbersome.This PR adds a Tokens cache similar to our tradablePairs cache.
Means UIs can now synchronously import Token data which makes the UI code much simpler.
How To Test
yarn cacheTokensto see it work