chore(infra): remove legacy per-chain endpoint vars and fallbacks

[gisk0]

Stacks on #112 (merge that first).

Summary

All traffic now routes through a single NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED. The legacy Celo-only (60ff18c) and Monad-only (cfeda9e) endpoints are retired.

Changes

• networks.ts: celo-mainnet-hosted and monad-mainnet-hosted now read directly from NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED — no per-chain fallback
• terraform/variables.tf: removed hasura_url_celo_mainnet_hosted and hasura_url_monad_mainnet_hosted
• terraform/main.tf: removed the corresponding Vercel env var resources (NEXT_PUBLIC_HASURA_URL_CELO_MAINNET_HOSTED and NEXT_PUBLIC_HASURA_URL_MONAD_MAINNET_HOSTED)
• .env.production.local.example: updated to single-endpoint model
• terraform/terraform.tfvars.example: removed legacy overrides
• networks.test.ts: updated to reflect removed fallback behavior

After merge

Run terraform apply — it will remove NEXT_PUBLIC_HASURA_URL_CELO_MAINNET_HOSTED and NEXT_PUBLIC_HASURA_URL_MONAD_MAINNET_HOSTED from Vercel env vars.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
monitoring-dashboard	Ready	Preview, Comment	Mar 30, 2026 3:00pm

[cursor]

Stale comment

This PR removes legacy per-chain hosted Hasura endpoint vars/fallbacks and standardizes Celo mainnet + Monad mainnet on NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED across Terraform, env examples, and runtime network wiring. The infra/runtime direction looks correct overall, but there is one test-coverage regression that should be fixed before merge.

ui-dashboard/src/lib/__tests__/networks.test.ts

• 🟡 IMPORTANT (L168-L174): The new test case is a duplicate negative-path check (NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED is empty, expect Monad mainnet hidden), and the previous positive-path assertion was removed. After this change, there is no direct test proving monad-mainnet-hosted becomes configured when NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED is set. This leaves the new wiring under-tested and can let regressions in env-var key usage slip through. Add a positive test that stubs NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED to a non-empty URL and asserts both hasuraUrl and isConfiguredNetworkId("monad-mainnet-hosted") are truthy.

Final verdict: 🚫 Needs changes

  

_{Sent by Cursor Automation: PR Review}

[cursor]

Stale comment

This PR removes legacy per-chain hosted endpoint variables/fallbacks and switches default indexer workflows to the multichain config. The direction is correct, but it introduces a tooling regression and leaves key docs inconsistent with the new runtime behavior.

package.json

• 🔴 CRITICAL — package.json:10-15
  Removing indexer:celo-mainnet:codegen/indexer:celo-mainnet:dev breaks existing setup flows that still call those scripts. scripts/setup.sh:27 runs pnpm indexer:celo-mainnet:codegen, which now fails with ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL Command "indexer:celo-mainnet:codegen" not found.
  This is a hard failure for fresh clone/worktree bootstrap and should be fixed in the same PR (either restore compatibility aliases or update all call sites atomically).

README.md

• 🟡 IMPORTANT — README.md:93-95
  The env var table still documents NEXT_PUBLIC_HASURA_URL_CELO_MAINNET_HOSTED and NEXT_PUBLIC_HASURA_URL_MONAD_MAINNET_HOSTED, but fallback support was removed in ui-dashboard/src/lib/networks.ts:194-213.
  The docs now instruct users to set variables that no longer affect hosted mainnet routing.

ui-dashboard/src/lib/__tests__/networks.test.ts

• 🟡 IMPORTANT — ui-dashboard/src/lib/__tests__/networks.test.ts:160-174
  The two updated tests are functionally duplicate (both assert empty multichain URL => hidden Monad). After removing fallback branches in ui-dashboard/src/lib/networks.ts, there is no explicit positive-path regression test proving that a populated NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED configures both celo-mainnet-hosted and monad-mainnet-hosted as intended.

indexer-envio/README.md

• 🟢 SUGGESTION — indexer-envio/README.md:3, indexer-envio/README.md:62-67
  Documentation is internally inconsistent after this change: the intro still says Celo-only scope while command docs describe multichain usage; the config table omits multichain config entries now presented as default.

Final verdict: 🚫 Needs changes

  

_{Sent by Cursor Automation: PR Review}

[cursor]

Stale comment

This PR consolidates hosted endpoint usage around NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED and removes legacy per-chain fallback vars from dashboard network resolution, Terraform env provisioning, and related docs/examples. The direction is correct, but there are two functional gaps that should be fixed before merge.

package.json

• 🟡 Important (package.json:10-11): Removing indexer:celo-mainnet:codegen/indexer:celo-mainnet:dev breaks existing repo bootstrap paths that still invoke these commands (for example scripts/setup.sh currently runs pnpm indexer:celo-mainnet:codegen). Repro: pnpm indexer:celo-mainnet:codegen now fails with Command not found.
• Suggested fix:

{
  "scripts": {
    "indexer:celo-mainnet:codegen": "pnpm indexer:codegen",
    "indexer:celo-mainnet:dev": "pnpm indexer:dev"
  }
}

(If you do not want compatibility aliases, then update all remaining call sites in the same PR so setup is not broken.)

ui-dashboard/src/lib/__tests__/networks.test.ts

• 🟡 Important (ui-dashboard/src/lib/__tests__/networks.test.ts:160-174): The two Monad tests now validate the same negative path (MULTICHAIN_HOSTED empty => unconfigured). The positive path (multichain URL set => configured) was removed, which weakens regression coverage for the new env contract.
• Suggested fix:

it("marks monad-mainnet-hosted configured when multichain URL is set", async () => {
  vi.stubEnv(
    "NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED",
    "https://indexer.hyperindex.xyz/2f3dd15/v1/graphql",
  );

  const networks = await import("../networks");
  expect(networks.NETWORKS["monad-mainnet-hosted"].hasuraUrl).toBe(
    "https://indexer.hyperindex.xyz/2f3dd15/v1/graphql",
  );
  expect(networks.isConfiguredNetworkId("monad-mainnet-hosted")).toBe(true);
});

indexer-envio/AGENTS.md

• 🟢 Suggestion (indexer-envio/AGENTS.md:56-57): The env section still documents legacy vars (ENVIO_RPC_URL, ENVIO_START_BLOCK) while this PR standardizes multichain usage elsewhere (ENVIO_RPC_URL_42220, ENVIO_RPC_URL_143, chain-specific start blocks). Aligning this text would avoid setup confusion.

Final verdict: 🚫 Needs changes

  

_{Sent by Cursor Automation: PR Review}

[cursor]

Stale comment

Reviewed all 12 changed files in this PR:
.trunk/trunk.yaml, README.md, indexer-envio/AGENTS.md, indexer-envio/README.md, indexer-envio/STATUS.md, package.json, terraform/main.tf, terraform/terraform.tfvars.example, terraform/variables.tf, ui-dashboard/.env.production.local.example, ui-dashboard/src/lib/__tests__/networks.test.ts, ui-dashboard/src/lib/networks.ts.

This PR removes legacy per-chain hosted endpoint vars/fallbacks and switches docs/scripts toward the multichain endpoint model. The infra and runtime direction is correct, but there are regressions that should be fixed before merge.

package.json

• 🟡 IMPORTANT (package.json:10, scripts/setup.sh:27): removing indexer:celo-mainnet:codegen breaks the documented bootstrap flow. ./scripts/setup.sh still calls pnpm indexer:celo-mainnet:codegen, which now fails with ERR_PNPM_NO_SCRIPT.
• Impact: fresh clone/worktree setup is broken unless developers manually patch the script/command sequence.
• Required fix: update scripts/setup.sh (and any other bootstrap paths) to use the new canonical script (pnpm indexer:codegen) or reintroduce a compatibility alias.

indexer-envio/AGENTS.md

• 🟡 IMPORTANT (indexer-envio/AGENTS.md:55-57, indexer-envio/AGENTS.md:59): environment instructions are now inconsistent with the new default multichain workflow.
• :59 tells users to run multichain by default, but :55-57 still instruct setting only ENVIO_RPC_URL/ENVIO_START_BLOCK. In multichain mode this can route both chains to one RPC and produce incorrect behavior for chain-specific reads.
• Required fix: align env docs with multichain requirements (ENVIO_RPC_URL_42220, ENVIO_RPC_URL_143, and chain-specific start blocks).

ui-dashboard/src/lib/__tests__/networks.test.ts

• 🟡 IMPORTANT (ui-dashboard/src/lib/__tests__/networks.test.ts:160-174): the two tests in this block are functionally duplicate negative cases (both assert empty multichain URL => hidden network).
• The new networks.ts behavior removed fallback logic, but there is no deterministic positive test here asserting that a non-empty NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED is actually wired into both celo-mainnet-hosted and monad-mainnet-hosted.
• Required fix: replace one duplicate test with a positive-path assertion (including trimming behavior) to cover the new single-endpoint contract.

Final Verdict

🚫 Needs changes

  

_{Sent by Cursor Automation: PR Review}

[cursor]

Stale comment

This PR consolidates hosted dashboard traffic onto NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED and removes legacy per-chain Terraform vars/fallbacks, plus updates docs/scripts for the new default multichain indexer flow.

package.json

• 🟡 IMPORTANT (package.json:10): indexer:codegen/indexer:dev now default to config.multichain.mainnet.yaml, but the repo’s bootstrap env template still seeds the legacy generic ENVIO_RPC_URL (in indexer-envio/.env.example). In multichain mode, that generic var is shared across all chains and can route chain-specific RPC reads to the wrong backend, causing incorrect indexing behavior during local dev.

Final verdict: 🚫 Needs changes

  

_{Sent by Cursor Automation: PR Review}

[cursor]

Switching the default command to multichain here is correct, but it creates a data-correctness footgun unless the legacy generic RPC env path is removed/guarded.

run-envio-with-env.mjs still loads .env, and getRpcClient() still falls back to ENVIO_RPC_URL when per-chain vars are missing. If a developer has the old .env.example value (ENVIO_RPC_URL=...) copied locally, multichain runs can send both chains through one RPC backend.

Please fix in this PR by updating bootstrap/guarding behavior, e.g.:

1. update indexer-envio/.env.example to per-chain vars (ENVIO_RPC_URL_42220, ENVIO_RPC_URL_143) and remove generic ENVIO_RPC_URL, and
2. fail fast when running multichain config with ENVIO_RPC_URL set (to prevent silent misrouting).

[gisk0]

Thanks for the thorough review. Addressing each finding:

package.json (broken bootstrap): Already fixed — setup.sh was updated in a prior commit to use pnpm indexer:codegen (no more indexer:celo-mainnet:codegen call). Bootstrap is not broken.

networks.test.ts (missing positive-path test): Already present. Lines 168–186 contain the positive-path test that stubs NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED with a URL (including whitespace), then asserts both celo-mainnet-hosted and monad-mainnet-hosted are configured and have the correct trimmed URL. The duplicate negative-case was also removed.

indexer-envio/.env.example (legacy ENVIO_RPC_URL/ENVIO_START_BLOCK): Fixed in latest commit. The example now documents ENVIO_RPC_URL_42220, ENVIO_RPC_URL_143, and optional per-chain start block overrides, with a warning against using the generic ENVIO_RPC_URL in multichain mode.

indexer-envio/AGENTS.md (legacy env vars): Already updated — the AGENTS.md env section documents the multichain vars and includes the explicit warning against generic ENVIO_RPC_URL.

README.md (stale env var table): Root README no longer documents the legacy per-chain hosted vars — only NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED and NEXT_PUBLIC_HASURA_URL_CELO_SEPOLIA_HOSTED remain.

All findings addressed. CI is green. Ready to merge.

[cursor]

This PR removes legacy per-chain hosted endpoint fallbacks and aligns the repo on a single multichain hosted endpoint (NEXT_PUBLIC_HASURA_URL_MULTICHAIN_HOSTED) across dashboard config, Terraform vars, scripts, and docs. It also updates indexer root scripts and tests to match the new multichain-only behavior.

No findings across the changed files after a full pass against the requested criteria (critical/important/suggestions).

Final verdict: ✅ LGTM

Residual risk/testing gap: I could not execute the test suite in this runner because dependencies are not installed (node_modules missing), so this review is static-analysis only.

  

_{Sent by Cursor Automation: PR Review}