fix: change the salinity file path to get variable

[josuemtzmo]

Hello,

This is a really simple fix in the buoyancy flux computation. The issue was when using the flag '-s', the code will crash saying that no variable could be found. The issue was that in the code, the salinity variable was searched in the temperature file, despite the -s option that allows to input a different file source. The fix, is simply to use the other already defined variable in case the option -s is used. Within the code it is already included the case in which the flag -s is not use, to re-defined as to be the same file as the temperature:

CDFTOOLS/src/cdfbuoyflx.f90

Line 179 in f3b5712

IF ( cf_sfil == 'none' ) cf_sfil=cf_tfil

[josuemtzmo]

I haven't check if other computations have a similar issue, but it may be worth investigating.

[molines]

Thank you for pointing this problem I fix it now. The issue was in reading surface salinity Cheers Jean-Marc

…

On 20/02/2023 10:56, Josué Martínez Moreno wrote: Hello, This is a really simple fix in the buoyancy flux computation. The issue was when using the flag '-s', the code will crash saying that no variable could be found. The issue was that in the code, the salinity variable was searched in the temperature file, despite the |-s| option that allows to input a different file source. The fix, is simply to use the other already defined variable in case the option |-s| is used. Within the code it is already included the case in which the flag |-s| is not use, to re-defined as to be the same file as the temperature: CDFTOOLS/src/cdfbuoyflx.f90 <https://github.com/meom-group/CDFTOOLS/blob/f3b5712134f259ef0e9bb11b10502f755a985821/src/cdfbuoyflx.f90#L179> Line 179 in f3b5712 </meom-group/CDFTOOLS/commit/f3b5712134f259ef0e9bb11b10502f755a985821> IF ( cf_sfil == 'none' ) cf_sfil=cf_tfil ------------------------------------------------------------------------ You can view, comment on, or merge this pull request online at: #54 Commit Summary * 9ea9795 <9ea9795> fix: change the salinity file path to get variable File Changes (1 file <https://github.com/meom-group/CDFTOOLS/pull/54/files>) * *M* src/cdfbuoyflx.f90 <https://github.com/meom-group/CDFTOOLS/pull/54/files#diff-29f48ca8963bf924f85f89cbd814bd1fa7b94bbc38ebf109e08efd1049b766ec> (2) Patch Links: * https://github.com/meom-group/CDFTOOLS/pull/54.patch * https://github.com/meom-group/CDFTOOLS/pull/54.diff — Reply to this email directly, view it on GitHub <#54>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFJFLTC5MRYM5RTJ55B7W53WYM5VTANCNFSM6AAAAAAVBVC5GU>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Jean-Marc Molines Modélisation de l'océan / Ingénieur de recherche IGE (UMR5001 / UR 252) /CNRS, Grenoble INP, IRD, et UGA/ Institut des Géosciences de l'Environnement MEOM/IGE UGA CS 40 700 38058 Grenoble cedex 9 Tél. :04 38 38 81 63 (Nouveau ! ) Web :http://www.ige-grenoble.fr/ Twitter : @IGE_Grenoble

[josuemtzmo]

I've found another issue with the buoyancy computation. For more info, refer to #55