Skip to content

Add a shim for grep-edit #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DogLooksGood merged 1 commit into from
Jul 16, 2025
Merged

Add a shim for grep-edit #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions meow-shims.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,28 @@
(advice-remove 'wgrep-finish-edit #'meow--switch-to-motion)
(advice-remove 'wgrep-save-all-buffers #'meow--switch-to-motion)))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; grep-edit


(defvar meow--grep-edit-setup nil
"Wheter already setup grep-edit.")

(defvar grep-edit-mode-hook)

(declare-function grep-edit-save-changes "grep")

(defun meow--setup-grep-edit (enable)
"Setup grep-edit.

Argument ENABLE non-nil means turn on."
(if enable
(progn
(add-hook 'grep-edit-mode-hook #'meow--switch-to-normal)
(advice-add #'grep-edit-save-changes :after #'meow--switch-to-motion))
(remove-hook 'grep-edit-mode-hook #'meow--switch-to-normal)
(advice-remove 'grep-edit-save-changes #'meow--switch-to-motion)))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; wdired

Expand Down Expand Up @@ -399,12 +421,12 @@
which-key-use-C-h-commands nil
meow-keypad-describe-keymap-function
(lambda (keymap)
(which-key--create-buffer-and-show nil keymap nil (concat meow-keypad-message-prefix (meow--keypad-format-keys))))

Check failure on line 424 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (27.1, true) 

You should depend on (emacs "30.1") if you need `which-key--create-buffer-and-show'.

Check failure on line 424 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (28.2, true) 

You should depend on (emacs "30.1") if you need `which-key--create-buffer-and-show'.
meow-keypad-clear-describe-keymap-function 'which-key--hide-popup)

(setq meow-keypad-describe-keymap-function 'meow-describe-keymap
meow-keypad-clear-describe-keymap-function nil
which-key-use-C-h-commands t)))

Check warning on line 429 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (27.1, true) 

assignment to free variable `which-key-use-C-h-commands'

Check warning on line 429 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (28.2, true) 

assignment to free variable `which-key-use-C-h-commands'

(defun meow--setup-which-key (enable)
"Setup which-key.
Expand Down Expand Up @@ -540,14 +562,15 @@
(meow--setup-eldoc t)
(meow--setup-rectangle-mark t)

(eval-after-load "macrostep" (lambda () (meow--setup-macrostep t)))

Check warning on line 565 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (27.1, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.

Check warning on line 565 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (28.2, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.
(eval-after-load "wdired" (lambda () (meow--setup-wdired t)))

Check warning on line 566 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (27.1, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.

Check warning on line 566 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (28.2, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.
(eval-after-load "edebug" (lambda () (meow--setup-edebug t)))

Check warning on line 567 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (27.1, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.

Check warning on line 567 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (28.2, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.
(eval-after-load "magit" (lambda () (meow--setup-magit t)))

Check warning on line 568 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (27.1, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.

Check warning on line 568 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (28.2, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.
(eval-after-load "wgrep" (lambda () (meow--setup-wgrep t)))

Check warning on line 569 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (27.1, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.

Check warning on line 569 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (28.2, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.
(eval-after-load "grep" (lambda () (meow--setup-grep-edit t)))

Check warning on line 570 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (27.1, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.

Check warning on line 570 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (28.2, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.
(eval-after-load "company" (lambda () (meow--setup-company t)))

Check warning on line 571 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (27.1, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.

Check warning on line 571 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (28.2, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.
(eval-after-load "corfu" (lambda () (meow--setup-corfu t)))

Check warning on line 572 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (27.1, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.

Check warning on line 572 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (28.2, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.
(eval-after-load "polymode" (lambda () (meow--setup-polymode t)))

Check warning on line 573 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (27.1, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.

Check warning on line 573 in meow-shims.el

View workflow job for this annotation

GitHub Actions / check (28.2, true) 

`eval-after-load' is for use in configurations, and should rarely be used in packages.
(eval-after-load "cider" (lambda () (meow--setup-cider t)))
(eval-after-load "sly" (lambda () (meow--setup-sly t)))
(eval-after-load "realgud" (lambda () (meow--setup-realgud t)))
Expand All @@ -571,6 +594,7 @@
(when meow--company-setup (meow--setup-company nil))
(when meow--corfu-setup (meow--setup-corfu nil))
(when meow--wgrep-setup (meow--setup-wgrep nil))
(when meow--grep-edit-setup (meow--setup-grep-edit nil))
(when meow--polymode-setup (meow--setup-polymode nil))
(when meow--cider-setup (meow--setup-cider nil))
(when meow--which-key-setup (meow--setup-which-key nil))
Expand Down