Skip to content

Comments

Lower the priority of normal keymap and remove some shims#664

Merged
DogLooksGood merged 1 commit intomasterfrom
low-priority-normal-keymap
Nov 10, 2024
Merged

Lower the priority of normal keymap and remove some shims#664
DogLooksGood merged 1 commit intomasterfrom
low-priority-normal-keymap

Conversation

@DogLooksGood
Copy link
Collaborator

All keymap in meow had the high priority by setting emulation-mode-map-alists. In normal state, the result is every minor mode single key commands are covered by normal mode commands. We added a lot shims to work out of this, however it doesn't seems to be necessary to me.

By lowering the keymap's priority, we can get rid of some shims, e.g. edebug, company, corfu, magit-blame, etc. They just work now.

@gs-101
Copy link
Contributor

gs-101 commented Nov 8, 2024

Just tested this PR with package-vc-install (and recompiling and restarting just to be safe) and my motion keys just executed self-insert-command instead of navigation commands with grep-edit. So #656 is still valid (just how the wgrep shim still is I'd guess, since you didn't remove it in this commit).

@DogLooksGood
Copy link
Collaborator Author

I want to have a automatic normal/motion switching by detecting if there's an self-insert-command bound to single keys. there may be some tricky edge cases, I'll give it a try.

@DogLooksGood DogLooksGood force-pushed the low-priority-normal-keymap branch from 29ec89f to 9b1bfd9 Compare November 8, 2024 12:49
@DogLooksGood DogLooksGood merged commit 38af7f1 into master Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants