Unset insert-exit-key when it isn't needed anymore#774
Open
ventruvian wants to merge 1 commit intomeow-edit:masterfrom
Open
Unset insert-exit-key when it isn't needed anymore#774ventruvian wants to merge 1 commit intomeow-edit:masterfrom
ventruvian wants to merge 1 commit intomeow-edit:masterfrom
Conversation
- `meow--beacon-insert-enter-key` previously stayed around - This didn't produce any issues since it was unset by meow-beacon-start - However cleaning it up makes it an indicator for whether or not recording takes place. This can be helpful for user-code or other packages. - This behaviour seems more consistent otherwise it's meaning changes before the first invokcation of beacon- mode and after.
Collaborator
|
I think there's no harm to reset it. But why not use |
Author
|
That was the first thing I attempted, but it was I realize now that I was mistaken: It is not " I need to know if insert-functions are called from a kbd macro previously defined with beacon. I did try to switch on As far as I have investigated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meow--beacon-insert-enter-keypreviously stayed aroundwhether or not recording takes place. This can be helpful for user-code or other packages. Edit: My mistake, it is not macro recording that this indicates, but execution from beaconI resort to advicing this function to determine if
recordingmacro-execution is taking place, here for example.Not sure if that is a good way to do it, but regardless it seems like good style to clean this variable up.