Add support for JCHENG SECURITY Contact and PIR sensors#3448
Draft
hertzg wants to merge 1 commit intomerbanan:masterfrom
Draft
Add support for JCHENG SECURITY Contact and PIR sensors#3448hertzg wants to merge 1 commit intomerbanan:masterfrom
hertzg wants to merge 1 commit intomerbanan:masterfrom
Conversation
Add decoders for JCHENG SECURITY sensors: - Contact Sensor: door/window sensor with 16-bit ID - PassiveIR Sensor: PIR motion sensor with 12-bit ID Both use OOK PWM modulation at 433.92MHz with 25-bit messages. Disabled by default as there is no checksum/CRC.
Collaborator
|
Thanks! The code looks great. If there is no checksum and no advanced decoding I'd always recommend to use a flex decoder. Given that there is the 0xa/0xaa check it might warrant a full decoder though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add decoders for JCHENG SECURITY sensors:
Jcheng-Contact): Door/window contact sensor with 16-bit ID, reports closed state, battery status, and event flagJcheng-PIR): PIR motion sensor with 12-bit ID, reports motion, tamper, and battery statusBoth sensors use OOK PWM modulation at 433.92MHz with 25-bit messages.
Protocol Details
Contact Sensor (25 bits):
PIR Sensor (25 bits):
Notes
-R 292(contact) or-R 293(PIR)Test data
I can provide test recordings for the Contact Sensor only. Unfortunately, I no longer have the PIR sensor device.
@zuckschwerdt: Would you prefer I remove the PIR decoder from this PR and submit it as Contact Sensor only? I can add the PIR decoder later if/when I have access to the device again.
Test plan