Skip to content

Conversation

@hanks
Copy link

@hanks hanks commented Oct 8, 2019

WHAT

Extract the action part of terraform plan, to help us to focus on the more important part during code review.

WHY

Sometimes we found the part about Refreshing Terraform state in-memory prior to plan
has too many lines that we do not need to care about in the code review. So make this
change can help us to focus on the action part that terraform plan is.

DEMO

The Action part will be content below:

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  + google_compute_global_address.my_another_project
      id:         <computed>
      address:    <computed>
      ip_version: "IPV4"
      name:       "my-another-project"
      project:    "my-project"
      self_link:  <computed>

@hanks hanks requested review from babarot and dtan4 as code owners October 8, 2019 05:40
@hanks hanks force-pushed the feat/extract-action-from-body branch 2 times, most recently from 7930fef to 458f15c Compare October 8, 2019 05:53
@hanks
Copy link
Author

hanks commented Oct 8, 2019

This PR is spirited by #11, but it is closed, it is a good idea for code review, so I try to make this happen again. Thank you for your time.

@hanks hanks force-pushed the feat/extract-action-from-body branch 2 times, most recently from 70df13e to a05eeac Compare October 8, 2019 06:31
@hanks
Copy link
Author

hanks commented Oct 21, 2019

@dtan4 @b4b4r07 Hi, would you be able to check this PR at your earliest convenience, thank you for your time.

@babarot
Copy link
Contributor

babarot commented Mar 2, 2020

Thank you for the contribution! This is really nice, please wait a bit more to be reviewed..!

@babarot
Copy link
Contributor

babarot commented Mar 2, 2020

Code seems good. But actually it didn't work well. I tested this it in local but no action part was not shown.

@hanks hanks force-pushed the feat/extract-action-from-body branch 2 times, most recently from 94ab83c to 0d69b99 Compare May 11, 2020 08:26
**Why**
Sometimes we found the part about `Refreshing Terraform state in-memory prior to plan`
has too many lines that we do not need to care about in the code review. So make this
change can help us to focus on the action part that terraform plan is.
@hanks hanks force-pushed the feat/extract-action-from-body branch from 0cd13ec to 9d42044 Compare May 11, 2020 08:57
@hanks
Copy link
Author

hanks commented May 11, 2020

@b4b4r07 Thanks for the comment! Since it is a very old PR, and introduced many complicated from last master branch, so I did a rebase and solved the conflicts.

May I ask a question: How to test in local? Like I use terraform plan | tfnotify --config=.tfnotify.yaml plan, and added some fmt.Println for the debug, but I can not see any output from the terminal.

@mocyuto
Copy link

mocyuto commented Aug 28, 2020

I would want to use this feature. Is there any plan to progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants