Skip to content

MM2-1504: Fix: add length validation for description in edit/create attribute form #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: testing
Choose a base branch
from
Open

MM2-1504: Fix: add length validation for description in edit/create attribute form #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e92789
fix: add length validation for description in edit/create attribute form
sylwia-werner Nov 8, 2025
aa61be1
fix: attribute description text
sylwia-werner Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/routes/attributes/attribute-edit/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export type AdminUpdateAttributeType = z.infer<typeof AdminUpdateAttribute>;
export const AdminUpdateAttribute = z
.object({
name: z.string().optional(),
description: z.string().optional(),
description: z.string().max(250, { message: "Description must be at most 250 characters" }).optional(),
handle: z.string().optional(),
is_filterable: z.boolean().optional(),
is_required: z.boolean().optional(),
Expand All @@ -46,7 +46,7 @@ export const AdminUpdateAttribute = z
export type AdminCreateAttributeType = z.infer<typeof CreateAttribute>;
export const CreateAttribute = z.object({
name: z.string().min(1),
description: z.string().optional(),
description: z.string().max(250, { message: "Description must be at most 250 characters" }).optional(),
is_filterable: z.boolean().optional(),
is_required: z.boolean().optional(),
ui_component: z
Expand Down