Skip to content

MM2-1659 Fix: commision lines page throws error #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: testing
Choose a base branch
from
+9 −9
Open

MM2-1659 Fix: commision lines page throws error #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aff78f
fix: error on commision line details
sylwia-werner Nov 12, 2025
611e4b0
fix: correct display of data in commision detail modal
sylwia-werner Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/routes/commission-lines/components/commission-detail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,28 +60,28 @@ export function CommissionLineDetail({ line, open, close }: Props) {
<legend className="mt-4">Calculated commission value</legend>
<Container>
<div className="flex items-center justify-between">
<Text>{`${line.value} ${line.currency_code.toUpperCase()}`}</Text>
<Text>{`${line.value === null ? '-' : line.value} ${line.currency_code.toUpperCase()}`}</Text>
</div>
</Container>
</fieldset>
<fieldset className="mt-2">
<legend className="mt-4">Rate details</legend>
<Container>
<div className="flex flex-col gap-2">
<Text>{`Rule name: ${line.rule.name}`}</Text>
<Text>{`Reference: ${line.rule.reference}`}</Text>
<Text>{`Type: ${line.rule.rate.type}`}</Text>
{line.rule.rate.type === "percentage" && (
<Text>{`Rule name: ${line.rule?.name ?? '-'}`}</Text>
<Text>{`Reference: ${line.rule?.reference ?? '-'}`}</Text>
<Text>{`Type: ${line.rule?.rate?.type ?? '-'}`}</Text>
{line.rule?.rate.type === "percentage" && (
<>
<Text>{`Rate value: ${line.rule.rate.percentage_rate}%`}</Text>
<Text>{`Include tax: ${line.rule.rate.include_tax ? "Yes" : "No"}`}</Text>
<Text>{`Rate value: ${line.rule?.rate?.percentage_rate}%`}</Text>
<Text>{`Include tax: ${line.rule?.rate?.include_tax ? "Yes" : "No"}`}</Text>
</>
)}
{line.rule.deleted_at !== null && (
{line.rule?.deleted_at && (
<Text
size="large"
weight="plus"
>{`Rule was deleted at ${formatDate(line.rule.deleted_at)}!`}</Text>
>{`Rule was deleted at ${formatDate(line.rule?.deleted_at)}`}</Text>
)}
</div>
</Container>
Expand Down