MM2-1281: Fix TS errors pt 1 #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mikolvj
reviewed
Nov 10, 2025
Comment on lines
+9
to
+13
| type ExtendedAdminOrderFilters = HttpTypes.AdminOrderFilters & { | ||
| fulfillment_status?: string[] | ||
| payment_status?: string[] | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
how about moving this definition to src/types?
Comment on lines
+9
to
+12
| type ExtendedAdminProductListParams = HttpTypes.AdminProductListParams & { | ||
| tag_id?: string[] | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
how about moving this definition to src/types?
|
|
||
| const handleSubmit = async ( | ||
| params: { metadata?: Record<string, unknown> | null }, | ||
| callbacks: { onSuccess: () => void; onError: (error: FetchError | string) => void } |
Collaborator
There was a problem hiding this comment.
IMO onSuccess and onError should be optional - what do you think? (applies to all occurrences of this typing)
Comment on lines
+49
to
+52
| first_name: data.first_name || undefined, | ||
| last_name: data.last_name || undefined, | ||
| phone: data.phone || undefined, | ||
| company_name: data.company_name || undefined, |
Collaborator
There was a problem hiding this comment.
... || undefined seems uncorrect because left value must be undefined to apply this condition
|
|
||
| const onDuplicate = async () => { | ||
| if (!item.variant_id) { | ||
| toast.error("Cannot duplicate item: variant ID is missing") |
| const inventoryItemId = params.get("item_id") | ||
|
|
||
| if (!inventoryItemId) { | ||
| throw new Error("Inventory item ID is required") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: MM2-1437