Skip to content

MM2-1600: Add clickable button icon for input component #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: test
Choose a base branch
from
+27 −6
Open

MM2-1600: Add clickable button icon for input component #232

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44710de
fix: add clickable icon button to input component
sylwia-werner Nov 12, 2025
3da317e
refactor: remove unused import
sylwia-werner Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/components/atoms/Input/Input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,16 @@ import { cn } from "@/lib/utils"
import { CloseIcon } from "@/icons"
import { useEffect, useState } from "react"
import { EyeMini, EyeSlashMini } from "@medusajs/icons"
import { IconButton } from "../IconButton/IconButton"
Copy link
Collaborator

@kacpergumieniuk kacpergumieniuk Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not used so import can be removed

Copy link
Collaborator Author

@sylwia-werner sylwia-werner Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed


interface InputProps extends React.InputHTMLAttributes<HTMLInputElement> {
label?: string
icon?: React.ReactNode
clearable?: boolean
error?: boolean
changeValue?: (value: string) => void
onIconClick?: () => void
iconAriaLabel?: string
}

export function Input({
Expand All @@ -20,6 +23,8 @@ export function Input({
className,
error,
changeValue,
onIconClick,
iconAriaLabel,
...props
}: InputProps) {
const [showPassword, setShowPassword] = useState(false)
Expand Down Expand Up @@ -47,10 +52,20 @@ export function Input({
}

return (
<label className="label-md">
{label}
<div className="flex flex-col">
<label className="label-md">{label}</label>
<div className="relative mt-2">
{icon && (
{icon && onIconClick && (
<button
onClick={onIconClick}
className="flex items-center justify-center rounded-sm transition-all duration-300 ease-out button-transparent h-[32px] w-[32px] absolute top-[8px] left-[8px]"
aria-label={iconAriaLabel}
>
{icon}
</button>
)}

{icon && !onIconClick && (
<span className="absolute top-0 left-[16px] h-full flex items-center">
{icon}
</span>
Expand Down Expand Up @@ -87,6 +102,6 @@ export function Input({
</button>
)}
</div>
</label>
</div>
)
}
11 changes: 9 additions & 2 deletions src/components/molecules/NavbarSearch/NavbarSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,29 @@ export const NavbarSearch = () => {

const [search, setSearch] = useState(searchParams.get("query") || "")

const submitHandler = async (e: React.FormEvent<HTMLFormElement>) => {
e.preventDefault()
const handleSearch = () => {
if (search) {
redirect(`/categories?query=${search}`)
} else {
redirect(`/categories`)
}
}

const submitHandler = (e: React.FormEvent<HTMLFormElement>) => {
e.preventDefault()
handleSearch()
}

return (
<form className="flex items-center" method="POST" onSubmit={submitHandler}>
<Input
icon={<SearchIcon />}
onIconClick={handleSearch}
iconAriaLabel="Search"
placeholder="Search product"
value={search}
changeValue={setSearch}
type="search"
/>
<input type="submit" className="hidden" />
</form>
Expand Down