MM2-1696 Fix: seller logo shrinking on PDP and design fixes for seller section #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sylwia-werner
commented
Nov 14, 2025
sylwia-werner
commented
- fixed seller logo shrinking
- fixed seller section on PDP and Seller page
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kacpergumieniuk
requested changes
Nov 14, 2025
| @@ -1,5 +1,4 @@ | |||
| import LocalizedClientLink from "@/components/molecules/LocalizedLink/LocalizedLink" | |||
Collaborator
There was a problem hiding this comment.
We can get rid of this import
| </div> | ||
| </div> | ||
| {showArrow && ( | ||
| <LocalizedClientLink className="ml-auto" href={`/sellers/${seller.handle}`}> |
Collaborator
There was a problem hiding this comment.
We can incluide aria-label property in this component with matching value, to improve accessibility. example from the ProductCard.tsx: <LocalizedClientLink href={/products/${product.handle}} aria-label={View ${productName}} title={View ${productName}} >
Collaborator
Author
There was a problem hiding this comment.
that's right. In general the page accessibility is quite poor. It would be nice to pay more attention to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.