-
Notifications
You must be signed in to change notification settings - Fork 85
Sandbox/multiple cart checkout per seller #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NicolasGorga
wants to merge
43
commits into
mercurjs:develop
Choose a base branch
from
NicolasGorga:sandbox/multiple-cart-checkout-per-seller
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sandbox/multiple cart checkout per seller #35
NicolasGorga
wants to merge
43
commits into
mercurjs:develop
from
NicolasGorga:sandbox/multiple-cart-checkout-per-seller
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update README.md * refactor/eslint-prettier-config (mercurjs#2) * Fix/products (mercurjs#15) * refactor/esling-prettier-config * refactor/eslint-prettier-config (mercurjs#3) * feat: Home, Product listing, Product details, cart pages * Update README.md * refactor/eslint-prettier-config (mercurjs#2) * Hotfix/page promises (mercurjs#4) * feat: Home, Product listing, Product details, cart pages * refactor/esling-prettier-config * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * Update README.md Update Readme for B2C Storefront - Homepage * Update README.md * Hotfix/not found page (mercurjs#8) * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * Hotfix/product display (mercurjs#9) * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/product-display * Hotfix/product display (mercurjs#10) * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/product-display * hotfix/cart display * Hotfix/product display (mercurjs#11) * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/product-display * hotfix/cart display * hotfix/cart display * Hotfix/category fix (mercurjs#12) * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/product-display * hotfix/cart display * hotfix/cart display * hotfix/category-fix * Hotfix/metadata (mercurjs#13) * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/product-display * hotfix/cart display * hotfix/cart display * hotfix/category-fix * hotfix/metadata * Hotfix/metadata (mercurjs#14) * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/not-found-page * hotfix/product-display * hotfix/cart display * hotfix/cart display * hotfix/category-fix * hotfix/metadata * hotfix/metadata * README - add demo link * Update README.md * Update README.md Changed links to website * products regions fix --------- Co-authored-by: Tom Anioł <[email protected]> --------- Co-authored-by: Tom Anioł <[email protected]>
* Update README.md * refactor/eslint-prettier-config (mercurjs#2) * [MM2-200] - Product listing with ALgolia * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * algolia filtering fix * algolia filtering fix * algolia filtering fix * algolia filtering fix * algolia filtering fix * cart items fix * fix/algolia-sidebar * fix/images
* Update README.md * refactor/eslint-prettier-config (mercurjs#2) * [MM2-200] - Product listing with ALgolia * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * [MM2-201] - Algolia filtering * algolia filtering fix * algolia filtering fix * algolia filtering fix * algolia filtering fix * algolia filtering fix * cart items fix * fix/algolia-sidebar * fix/images * fix/wishlist-tabs
* fix/wishlist * fix/wishlist
* fix/wishlist * fix/wishlist * fix/product-listing-rwd
* fix/wishlist * fix/wishlist * fix/product-listing-rwd * product card fix
* fix/wishlist * fix/wishlist * fix/product-listing-rwd * product card fix * Product listing fix
* fix/wishlist * fix/wishlist * fix/product-listing-rwd * product card fix * Product listing fix * remove console.log * iphon fix
…orefront into develop Merge upstream
* fix/seller-page
* fix/products
* fix/images
* fix/products
* fix/products
…re can be multiple carts (for multiple seller products added)
…ceed to checkout individually
|
@NicolasGorga is attempting to deploy a commit to the Rigby Team Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @pfulara I woul ideally have pushed this against a separate branch, sanbox/multiple-cart-checkout-per-seller as it is not my intention to have it merged to develop nor main.
It's just if you were interested in exploring this alternative to Cart / Checkout management. In Centro (my startup), we adapted the Cart and Checkout flow, to have separate Cart / Checkout per Seller, so each Order and Fulfillment is individual per Seller. This is because Centro is in charge of coordinating the Fulfillment, receiving payments and everything else Order related.
You will see i changed the cookie management, to have a map of sellerHandle:cartId, so whenever a product is added to cart, for a seller that didn't have products added, i create an entry in the cookie. The other way around when an item is removed. I introduce a new Bag UI concept, which presents you with the list of carts created, so that you cna proceed individually to each checkout.
I have not yet altered the cart box to work with Bag, when hovering over the cart icon, but you can see the current Bag, by navigating to /bag.
Thanks for your email regarding status of checkout, I will go ahead and start implementing it for Centro and compare ot what you do when you start that feature.
Let me know what you think!