Draft
Conversation
anthonyduong9
force-pushed
the
feature/skip-scored
branch
from
7634b3f to
f6312b1
Compare
anthonyduong9
force-pushed
the
feature/skip-scored
branch
from
f6312b1 to
f6fbe26
Compare
| def _has_scanner_score(transcript_info: TranscriptInfo, scanner_name: str) -> bool: | ||
| """Check if transcript already has a score from this scanner.""" | ||
| if transcript_info.source_type != EVAL_LOG_SOURCE_TYPE: | ||
| return False |
There was a problem hiding this comment.
Why? Do only inspect logs support scores?
Note that the score could come from the original source (inspect eval log int his case) or from a previous scout scan
| state.scores = {scorer_name: Score(value=1)} | ||
| return state | ||
|
|
||
| return solve # type: ignore[return-value] |
There was a problem hiding this comment.
nit: Can we fix the argument name and remove type: ignore?
| f"Available tables: {table_names}" | ||
| ) | ||
|
|
||
| # Verify count first for clearer error messages |
There was a problem hiding this comment.
Why is this clearer?
If the expected value is [A, B, C] and real value is [A, B] I would much rather see the diff, which would let me see that C is missing. “Expected 3, got 2” seems much less helpful
There was a problem hiding this comment.
I like the exhaustiveness of the tests, but this feel a bit heavy. Can we simplify it? Maybe parametrize some of the tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.