Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
It's fine to defer merging this branch for a few days past Wednesday to be conservative.
It is a relatively safe change. The changes are all at the app router layer making ALL routes lazy. That is, there's no manually coded deferred imports within any of the panels. It's all at the panel level itself.
Summary
ScansPanel,ScanPanel,TranscriptsPanel,TranscriptPanel,ProjectPanel,ValidationPanel,ScannerResultPanel,RunScanPanel) withReact.lazy+ dynamicimport()<Outlet />in a<Suspense>boundary with<LoadingBar>as the fallbackelementproperty fromActivityConfigand its static panel imports inactivities.tsxMotivation
The initial JS bundle includes all route panels even though only one is rendered at a time. Lazy loading splits each panel into its own chunk, reducing the initial payload and improving time-to-interactive — especially for the common case where users land on a single route.
Impact
Initial download size per top level route (measured from browser network tab):
The biggest win comes from no longer eagerly loading MathJax (
tex-svg-full,xypic) on routes that don't render transcripts.