Conversation
Contributor
|
Note that the VS Code extension attempts to read the JS directly from the dist path in the repo (it doesn't get it over http) so we'll need to make sure to update it to be able to find these). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Based on #290 not
main. Most of the changes are from that branch.Summary
dist/to Git LFS — minified, tree-shaken, content-hashed build output is now committed as LFS pointer files (~130 bytes each) instead of full blobs, eliminating repo bloat from opaque minified diffs_view/_lfs/) — when a user clones without Git LFS installed,scout viewdetects pointer files at startup and downloads real assets from GitHub's LFS batch API into a local cache (~/.cache/inspect_scout/dist/), so the working tree is never modified[name]-[hash].js), allowing proper browser caching and removing theNoCacheStaticFilesworkaroundscripts/fetch-dist.shescape-hatch script for manual LFS object download outsidescout viewDesign
See design/plans/minified-via-lfs.md