Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5665 +/- ##
==========================================
- Coverage 5.85% 5.81% -0.05%
==========================================
Files 274 282 +8
Lines 41112 41485 +373
Branches 488 521 +33
==========================================
+ Hits 2408 2412 +4
- Misses 38704 39073 +369
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
sidharthv96
left a comment
There was a problem hiding this comment.
Great work @Vikrantpalle !!
Just some convention issues, and the langium change.
sidharthv96
left a comment
There was a problem hiding this comment.
Wonderful!!
All we need is some documentation and tests.
Existing tests can be found in cypress/integration/rendering
Documentation needs to be added in packages/mermaid/src/docs/syntax
|
@Vikrantpalle looks great to me! I'd say this PR is feature complete. 🚀 But treeView is a bit generic name to use for this diagram, as there are other issues/requests which could also be named a treeView. What are your thoughts on renaming this to something more specific? |
|
Maybe |
|
I feel like |
|
I think |
|
I would suggest TreeList. Because this is the purpose of it. |
|
I'm also leaning towards "Hierarchical Tree" is a tautology because "tree" already implies a hierarchical structure. So either The only issue I'm thinking is, if someone tries to write a file system diagram, they might not know what a |
|
I think documentation and examples is the way to go too. I think the only other way to solve the problem is explicitly mention Since both |
|
Throwing out an idea name, what about |
|
Hey quick comment on the langium file I saw that you were pasting the code from the common.langium into your file as opposed to importing it. If this is because it does not parse the |
|
I actually didn’t import the common file as whitespace is a hidden terminal in the common file, but is necessary to track indentation for the syntax. |
|
That makes sense. I feel like maybe the common should be separated out a bit. So if you import |
|
So exciting to see this nearing completion! Is there anything remaining? I'd love to use it 😉 |
+1 for fileTree |
Please refer to original PR by @Vikrantpalle : mermaid-js#5665 (comment)
|
Hi, I don't want to sound ungrateful, but what is left to do here? Anything we can help with? |
|
I cant wait for this to be feature complete as fed up with building ascii text folder structures!
|
|
Hi ! I see that the latest update was more than a year ago. Is there any news concerning this ? |
|
Conflicts have been resolved, and minor issues addressed, in this version |
|
Great to see this has traction again. Fantastic work @lee-treehouse |
📑 Summary
This PR introduces a new diagram named TreeView which displays hierarchical directory-like structures.
Resolves #2645
📷 Example
💻 Code
📏 Design Decisions
The features of the diagram focus on user flexibility and ease of use.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch