Closed
Conversation
chore: upgrade to Langium v4 and TypeScript v5.8 on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
Version Packages
* master: Version Packages Fixed issue with hero text
chore: Update banner with coupon
Reverts the global flowchart curve default from 'rounded' back to 'basis' and instead sets edge.curve = 'rounded' on each ELK edge right before insertEdge. This ensures ELK's orthogonal routes render with right-angle segments and rounded corners, without changing the default for non-ELK layouts. Fixes #7213 Co-authored-by: knsv-bot <knsv-bot@macos.shared> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…#7456) * fix(gantt): restore readable outside-text color for done tasks in dark mode When a Gantt done-task label is too wide to fit inside the bar, the renderer places the text outside (next to the bar) with class `taskTextOutsideLeft` or `taskTextOutsideRight` plus `doneText{N}`. The `.doneText{N}` rule uses `taskTextDarkColor !important`, which PR #7432 changed to a dark color (inverted from lightgrey) for contrast inside the bar. That `!important` also overrides the lighter `taskTextOutsideColor` that `.taskTextOutside{N}` sets, making outside-label text black/dark on the dark diagram background. Fix: add combined-class selectors (`.doneText{N}.taskTextOutsideLeft/Right`) after the `.doneText{N}` block, using `taskTextOutsideColor !important`. The combined selectors have higher specificity and appear later in the cascade, so they win over the single-class rule. Same fix applied to `.doneCritText{N}`. Fixes regression from PR #7432 (fix for #5979). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test(gantt): add e2e snapshot for done-task outside-text in dark mode Covers the regression from #7433 where done-task labels displayed outside the bar (text too wide for the bar width) rendered in unreadable dark color in dark theme. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test(gantt): add separate inside/outside e2e snapshots for dark mode done tasks Split the dark mode done-task coverage into two explicit tests: - inside-text: label fits within the bar (long bar, short label) - outside-text: label overflows the bar (short bar, long label) — regression case for #7433 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: knsv-bot <knsv-bot@macos.shared> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* 'master' of https://github.com/mermaid-js/mermaid: fix(gantt): restore readable outside-text for done tasks in dark mode (#7456) fix(elk): scope rounded edge curve to ELK layout only (#7454)
* fix: ER diagram edge label position when htmlLabels is false on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com> * chore: add changeset on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com> * fix: adjust edge label positioning for improved alignment on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com> * fix: add unit tests for centering logic on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com> * fix: add a flag to createTspan function to center edgeLabels when htmlLabels is false on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com> * fix: add e2e test , modify unit test Some optional description over here if you need to add more info on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com> * fix: update edges in dagre-wrapper, add tests on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Summary
This pull request includes several minor features and numerous bug fixes across different diagram types and rendering behaviors in the
mermaidpackage. The most notable updates are the addition of new diagram support and exportable types, improvements to SVG rendering and label handling, and fixes for diagram parsing and rendering issues.New features and exports:
venn-betadiagram, expanding the types of diagrams users can create.AsyncIconLoader,SyncIconLoader, andIconLoadertypes for external usage.SVG and label rendering improvements:
viewBoxcasing and made SVGs responsive for better rendering across devices.htmlLabelsMermaid config value and prevented HTML tag escaping in sandbox label rendering. [1] [2]markdownAutoWrap: falseandhtmlLabelsare enabled.Diagram parsing and rendering fixes:
Other diagram-specific fixes:
Resolves #
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.