Adds support for explicit TZ conversion requests#29
Merged
merschformann merged 4 commits intomainfrom May 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for explicit timezone conversion requests by allowing explicit timezone identifiers in addition to indexed timezone configurations. Key changes include updates to request parsing logic in the core package, new tests to verify explicit timezone support in tests/request_test.go, and updates to the README screenshots.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/request_test.go | Added tests for explicit timezone conversion requests |
| core/args.go | Updated function references and error messages for timezone parsing |
| README.md | Updated screenshots and added example usage for explicit TZ support |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for requesting conversion to explicitly given timezones. E.g., the following call returns 11:00 in London time, which is not necessarily part of the configured timezones.
Timezone names and options are based on IANA Time Zone database entries (same as for configured ones). Find them on this wiki page in the TZ identifier column.
Changes
gotz 1100@Europe/London)