-
Notifications
You must be signed in to change notification settings - Fork 50
Near-linear basis set dependency handling and level shifting for RHF/UHF/DFT/UDFT #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vtripath65
wants to merge
39
commits into
merzlab:master
Choose a base branch
from
vtripath65:linear_dep
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
c36da0c
near-linear dependency of basis functions reduced
vtripath65 598cd18
simplified the handling of low overlap matrix eig values]
vtripath65 c710ae3
rebasing after fixing cuda_diag
vtripath65 dc5aae6
overlap matrix threshold tightened
vtripath65 70d5371
reverted the diagmkl routine back to state in master
vtripath65 44a436a
removed the temporary basis sets
vtripath65 d4d2ffc
removed the remaining temporary basis sets
vtripath65 3d15608
Code cleanup and proper array allocation
vtripath65 f2c6a14
MPI works
vtripath65 922985e
CUDA code works for cases with no near-linear dependency and level sh…
vtripath65 abd18be
changes from master branch merged after simplifying the matrix multip…
vtripath65 f3467e4
reduced the basis-set near-linear dependency default cutoff
vtripath65 b94505d
use canoninical orthogonalization only in case of near-linear dependency
vtripath65 157bf90
some allocations are made conditional on the value of NBSuse
vtripath65 8662364
opencode generated AGENTS.md
vtripath65 fb68837
fix segfault in symmetric DIIS path by replacing oeff with o
vtripath65 28dd79e
fixing compilation error due to long lines
vtripath65 de673a5
missing line continuation
vtripath65 32ee544
The overlap matrix eigenvalue information is removed from testing
vtripath65 5ed1fb1
Level shifting not applied for first two steps by default
vtripath65 cf4538f
changed some comments better readability
vtripath65 9aed47e
tests are added and Level shifting printing fixed
vtripath65 ecde073
benzene test added to test near-linear dependency of basis sets
vtripath65 3b3c546
Caffeine test added to test near-linear dependency of basis sets
vtripath65 e1c2947
Level shift keywords are added
vtripath65 ab944d1
the mulliken charge computation is now using MAT_DGEMM
vtripath65 1021fd0
the Lowdin population analysis now uses MAT_DGEMM
vtripath65 aa8ffb4
the issue with Lowdin charges in case of near-linear dependency is no…
vtripath65 4bec1ba
fixed the test for Lowdin charges for near-linear basis set dependency
vtripath65 3a52cfb
Level shifting and near-linear dependency handling added to quick_usc…
vtripath65 0f8bdf6
added missing initializations before Lowdin charge calculation in dip…
vtripath65 963265a
tests are added for unrestricted case
vtripath65 439ecd1
missing input test files
vtripath65 d211b5e
updated branch by merging master
vtripath65 3bf6db3
removed commented out lines
vtripath65 834e1b8
remove AGENTS.md (not intended for upstream)
vtripath65 52cf9cd
Merge remote-tracking branch 'upstream/master' into linear_dep
agoetz 2eda400
removed unnecessary semicolon
vtripath65 12d047c
Merge branch 'linear_dep' of github.com:vtripath65/QUICK into linear_dep
vtripath65 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,6 +85,7 @@ module quick_molspec_module | |
|
|
||
| ! basis set number | ||
| integer, pointer:: nbasis | ||
| integer, pointer:: NBSuse | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For some reason quick_molspec%NBSuse does not really seem to be used. |
||
|
|
||
| end type quick_molspec_type | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't seem to use quick_qm_struct%NBSuse or quick_molspec%NBSuse