Skip to content

improve: add comprehensive type hints to LLMAgent and ModuleLLM #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinavk0220 wants to merge 11 commits into
base: main
Choose a base branch
from
+629 −351
Open

improve: add comprehensive type hints to LLMAgent and ModuleLLM #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
15df694
fix: migrate codebase to Mesa 4.x APIMesa 4.x removed mesa.space enti…
Mar 5, 2026
6baf6d7
fix: resolve merge conflict with upstream/main- Update test_inbuilt_t…
Mar 6, 2026
79d1dc2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 6, 2026
3150700
fix: resolve ruff linting errors (PLC0415, F841)
Mar 6, 2026
951a5c4
fix: move import math to top level (ruff PLC0415)
Mar 6, 2026
3bdc711
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 6, 2026
0b5dd9b
improve: add comprehensive type hints to LLMAgent and ModuleLLM- Add …
Mar 7, 2026
b4b207e
fix: resolve merge conflict - migrate test_llm_agent.py to Mesa 4.x A…
Mar 7, 2026
44ba636
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 7, 2026
4881c4f
fix: address CodeRabbit review comments- Fix neighbor.memory ownershi…
Mar 7, 2026
55f5d78
Merge branch 'improve/type-hints-llm-agent-module-llm' of https://git…
Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
275 changes: 275 additions & 0 deletions hell
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,275 @@
diff --cc tests/test_tools/test_inbuilt_tools.py
index fce291c,7a9c367..0000000
--- a/tests/test_tools/test_inbuilt_tools.py
+++ b/tests/test_tools/test_inbuilt_tools.py
@@@ -3,9 -3,9 +3,10 @@@ from __future__ import annotation
from types import SimpleNamespace

import pytest
 -from mesa.discrete_space import OrthogonalMooreGrid, OrthogonalVonNeumannGrid
 -from mesa.space import ContinuousSpace, MultiGrid, SingleGrid
 +from mesa.discrete_space import OrthogonalMooreGrid
 +from mesa.experimental.continuous_space import ContinuousSpace
 +
+ 
from mesa_llm.tools.inbuilt_tools import (
move_one_step,
speak_to,
@@@ -155,3 -329,256 +334,257 @@@ def test_move_one_step_on_continuousspa

assert agent.pos == (2.0, 3.0)
assert result == "agent 6 moved to (2.0, 3.0)."
+ 
+ 
+ def test_move_one_step_boundary_on_continuousspace():
+ model = DummyModel()
+ model.grid = None
+ model.space = ContinuousSpace(x_max=10.0, y_max=10.0, torus=False)
+ 
+ agent = DummyAgent(unique_id=30, model=model)
+ model.agents.append(agent)
+ model.space.place_agent(agent, (2.0, 9.0))
+ 
+ result = move_one_step(agent, "North")
+ 
+ assert agent.pos == (2.0, 9.0)
+ assert "boundary" in result.lower()
+ assert "North" in result
+ 
+ 
+ def test_move_one_step_torus_wrap_on_continuousspace():
+ model = DummyModel()
+ model.grid = None
+ model.space = ContinuousSpace(x_max=10.0, y_max=10.0, torus=True)
+ 
+ agent = DummyAgent(unique_id=31, model=model)
+ model.agents.append(agent)
+ model.space.place_agent(agent, (2.0, 9.0))
+ 
+ result = move_one_step(agent, "North")
+ 
+ assert agent.pos == (2.0, 0.0)
+ assert result == "agent 31 moved to (2.0, 0.0)."
+ 
+ 
+ def test_move_one_step_boundary_singlegrid_north():
+ """Agent at top edge of SingleGrid trying to go North gets a clear message."""
+ model = DummyModel()
+ model.grid = SingleGrid(width=5, height=5, torus=False)
+ 
+ agent = DummyAgent(unique_id=20, model=model)
+ model.agents.append(agent)
+ model.grid.place_agent(agent, (2, 4)) # y=4 is the top edge
+ 
+ result = move_one_step(agent, "North")
+ 
+ # agent should not have moved
+ assert agent.pos == (2, 4)
+ assert "boundary" in result.lower()
+ assert "North" in result
+ 
+ 
+ def test_move_one_step_torus_wrap_singlegrid_north():
+ model = DummyModel()
+ model.grid = SingleGrid(width=5, height=5, torus=True)
+ 
+ agent = DummyAgent(unique_id=23, model=model)
+ model.agents.append(agent)
+ model.grid.place_agent(agent, (2, 4))
+ 
+ result = move_one_step(agent, "North")
+ 
+ assert agent.pos == (2, 0)
+ assert result == "agent 23 moved to (2, 0)."
+ 
+ 
+ def test_move_one_step_boundary_multigrid_west():
+ """Agent at left edge of MultiGrid trying to go West gets a clear message."""
+ model = DummyModel()
+ model.grid = MultiGrid(width=5, height=5, torus=False)
+ 
+ agent = DummyAgent(unique_id=21, model=model)
+ model.agents.append(agent)
+ model.grid.place_agent(agent, (0, 2)) # x=0 is the left edge
+ 
+ result = move_one_step(agent, "West")
+ 
+ assert agent.pos == (0, 2)
+ assert "boundary" in result.lower()
+ assert "West" in result
+ 
+ 
+ def test_move_one_step_torus_wrap_multigrid_west():
+ model = DummyModel()
+ model.grid = MultiGrid(width=5, height=5, torus=True)
+ 
+ agent = DummyAgent(unique_id=24, model=model)
+ model.agents.append(agent)
+ model.grid.place_agent(agent, (0, 2))
+ 
+ result = move_one_step(agent, "West")
+ 
+ assert agent.pos == (4, 2)
+ assert result == "agent 24 moved to (4, 2)."
+ 
+ 
+ def test_move_one_step_singlegrid_occupied_target():
+ model = DummyModel()
+ model.grid = SingleGrid(width=5, height=5, torus=False)
+ 
+ moving_agent = DummyAgent(unique_id=25, model=model)
+ blocking_agent = DummyAgent(unique_id=26, model=model)
+ model.agents.extend([moving_agent, blocking_agent])
+ model.grid.place_agent(moving_agent, (2, 2))
+ model.grid.place_agent(blocking_agent, (2, 3))
+ 
+ result = move_one_step(moving_agent, "North")
+ 
+ assert moving_agent.pos == (2, 2)
+ assert blocking_agent.pos == (2, 3)
+ assert "occupied" in result.lower()
+ assert "North" in result
+ 
+ 
+ def test_move_one_step_boundary_orthogonal_grid():
+ """Agent at edge of OrthogonalMooreGrid with no cell in that direction gets a clear message."""
+ 
+ class _DummyOrthogonalGrid(OrthogonalMooreGrid):
+ pass
+ 
+ orth_grid = object.__new__(_DummyOrthogonalGrid)
+ orth_grid.torus = False
+ orth_grid.dimensions = (5, 5)
+ start = (0, 1)
+ start_cell = SimpleNamespace(
+ coordinate=start, agents=[], connections={}, is_full=False
+ )
+ orth_grid._cells = {start: start_cell}
+ 
+ model = DummyModel()
+ model.grid = orth_grid
+ 
+ agent = DummyAgent(unique_id=22, model=model)
+ agent.cell = start_cell
+ model.agents.append(agent)
+ 
+ result = move_one_step(agent, "North")
+ 
+ # cell should be unchanged
+ assert agent.cell is start_cell
+ assert "boundary" in result.lower()
+ assert "North" in result
+ 
+ 
+ def test_move_one_step_boundary_orthogonal_torus_missing_wrapped_cell():
+ class _DummyOrthogonalGrid(OrthogonalMooreGrid):
+ pass
+ 
+ orth_grid = object.__new__(_DummyOrthogonalGrid)
+ orth_grid.torus = True
+ orth_grid.dimensions = (3, 3)
+ start = (0, 0)
+ start_cell = SimpleNamespace(coordinate=start, agents=[], is_full=False)
+ # Wrapped target for North would be (2, 0), but it is intentionally absent.
+ orth_grid._cells = {start: start_cell}
+ 
+ model = DummyModel()
+ model.grid = orth_grid
+ 
+ agent = DummyAgent(unique_id=38, model=model)
+ agent.cell = start_cell
+ model.agents.append(agent)
+ 
+ result = move_one_step(agent, "North")
+ 
+ assert agent.cell is start_cell
+ assert "boundary" in result.lower()
+ assert "North" in result
+ 
+ 
+ def test_move_one_step_full_target_orthogonal_grid():
+ class _DummyOrthogonalGrid(OrthogonalMooreGrid):
+ pass
+ 
+ orth_grid = object.__new__(_DummyOrthogonalGrid)
+ orth_grid.torus = False
+ orth_grid.dimensions = (5, 5)
+ start = (1, 1)
+ end = (0, 1)
+ start_cell = SimpleNamespace(
+ coordinate=start, agents=[], connections={}, is_full=False
+ )
+ full_target_cell = SimpleNamespace(
+ coordinate=end,
+ agents=[SimpleNamespace(unique_id=99)],
+ connections={},
+ is_full=True,
+ )
+ start_cell.connections[(-1, 0)] = full_target_cell
+ orth_grid._cells = {start: start_cell, end: full_target_cell}
+ 
+ model = DummyModel()
+ model.grid = orth_grid
+ 
+ agent = DummyAgent(unique_id=27, model=model)
+ agent.cell = start_cell
+ model.agents.append(agent)
+ 
+ result = move_one_step(agent, "North")
+ 
+ assert agent.cell is start_cell
+ assert "full" in result.lower()
+ assert "North" in result
+ 
+ 
+ def test_move_one_step_diagonal_on_orthogonal_vonneumann_grid():
+ class _DummyOrthogonalVonNeumannGrid(OrthogonalVonNeumannGrid):
+ pass
+ 
+ orth_grid = object.__new__(_DummyOrthogonalVonNeumannGrid)
+ orth_grid.torus = False
+ orth_grid.dimensions = (5, 5)
+ start = (2, 2)
+ end = (1, 3) # NorthEast
+ start_cell = SimpleNamespace(coordinate=start, agents=[], is_full=False)
+ end_cell = SimpleNamespace(coordinate=end, agents=[], is_full=False)
+ orth_grid._cells = {start: start_cell, end: end_cell}
+ 
+ model = DummyModel()
+ model.grid = orth_grid
+ 
+ agent = DummyAgent(unique_id=28, model=model)
+ agent.cell = start_cell
+ model.agents.append(agent)
+ 
+ result = move_one_step(agent, "NorthEast")
+ 
+ assert agent.cell is end_cell
+ assert result == "agent 28 moved to (1, 3)."
+ 
+ 
+ def test_move_one_step_torus_wrap_orthogonal_grid():
+ class _DummyOrthogonalGrid(OrthogonalMooreGrid):
+ pass
+ 
+ orth_grid = object.__new__(_DummyOrthogonalGrid)
+ orth_grid.torus = True
+ orth_grid.dimensions = (3, 3)
+ start = (0, 0)
+ end = (2, 2) # NorthWest wraps on torus
+ start_cell = SimpleNamespace(coordinate=start, agents=[], is_full=False)
+ wrapped_cell = SimpleNamespace(coordinate=end, agents=[], is_full=False)
+ orth_grid._cells = {start: start_cell, end: wrapped_cell}
+ 
+ model = DummyModel()
+ model.grid = orth_grid
+ 
+ agent = DummyAgent(unique_id=29, model=model)
+ agent.cell = start_cell
+ model.agents.append(agent)
+ 
+ result = move_one_step(agent, "NorthWest")
+ 
+ assert agent.cell is wrapped_cell
+ assert result == "agent 29 moved to (2, 2)."
++
Comment on lines +1 to +275
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Remove the stray patch artifact.

This file is checked-in diff text for tests/test_tools/test_inbuilt_tools.py, not source. It duplicates content already under tests/ and looks like an unresolved patch/merge artifact, so it should be dropped from the PR.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@hell` around lines 1 - 275, Remove the stray merge/diff artifact file named
"hell" that contains the checked-in patch text for
tests/test_tools/test_inbuilt_tools.py; delete this file from the PR (or revert
the commit that introduced it) so only the real
tests/test_tools/test_inbuilt_tools.py remains in the changeset and no
duplicated diff text is checked in.

Loading