Fix Asynchronous Event Loop Blocking in Mesa-LLM Parallel Stepping#176
Open
Nandhan-Golla wants to merge 2 commits intomesa:mainfrom
Open
Fix Asynchronous Event Loop Blocking in Mesa-LLM Parallel Stepping#176Nandhan-Golla wants to merge 2 commits intomesa:mainfrom
Nandhan-Golla wants to merge 2 commits intomesa:mainfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes asynchronous event loop blocking when executing synchronous
agent.step()functions and synchronous tool calls during parallel agent execution.Bug / Issue
When utilizing
parallel_stepping.py's asynchronous concurrency features in Mesa-LLM, standard Mesa Agents invoking the synchronousagent.step()method were doing so directly inside theasyncioevent loop. Similarly, non-async tool functions parsed insidetools/tool_manager.pywere invoked synchronously. Because Pythonasyncioruns on a single thread, any long-running or computationally expensive synchronous method call fully blocked the entire event loop, stalling all agents from operating concurrently and adding significant latency.Implementation
mesa_llm/parallel_stepping.py: Updated_sync_stepfunction to useawait asyncio.to_thread(agent.step)instead of blindly callingagent.step().mesa_llm/tools/tool_manager.py: Updated_process_tool_callto check if a function is synchronous. If so, it invokes the tool usingawait asyncio.to_thread(function_to_call, **filtered_args).Code Changes:
Testing
test_parallel_stepping.pyandtest_toolstest directories usingpytest.Pytest Output:
Additional Notes
This correctly delegates blocking sync I/O calls to background threads, yielding control back to the
asyncioevent loop and providing major latency and concurrency improvements in large Mesa agent simulations.