fix(memory): prevent oldest entry from dropping in STLTMemory#191
fix(memory): prevent oldest entry from dropping in STLTMemory#191Harshitmehra-270709 wants to merge 2 commits intomesa:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
IlamaranMagesh
left a comment
There was a problem hiding this comment.
There are already PRs and issues opened on this. Please look into it #107
Fixes #186
Describe the bug
STLTMemory._process_step_core() was previously prematurely popping the oldest entry from the short_term_memory queue before the LLM could summarize it via _update_long_term_memory(). This resulted in the oldest memory being completely lost.
The Solution