Feature/workspace #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryde
force-pushed
the
feature/workspace
branch
2 times, most recently
from
e12c449 to
73723cb
Compare
nroi
approved these changes
Jul 30, 2025
Contributor
nroi
left a comment
nroi
left a comment
There was a problem hiding this comment.
lgtm, but I've never written any code in go and have only little familiarity with terraform, so perhaps wait for Jo's review.
henryde
force-pushed
the
feature/workspace
branch
3 times, most recently
from
74c9aae to
72c377e
Compare
henryde
force-pushed
the
feature/workspace
branch
from
72c377e to
1432c70
Compare
henryde
force-pushed
the
feature/workspace
branch
2 times, most recently
from
9d69cbd to
0b228de
Compare
malhussan
approved these changes
Aug 1, 2025
Member
malhussan
left a comment
malhussan
left a comment
There was a problem hiding this comment.
lgtm! can you also add an example for workspace import
# import via workspace identifier
terraform import 'meshstack_workspace.example' 'my-workspace-identifier'
henryde
force-pushed
the
feature/workspace
branch
from
0b228de to
98ccb7e
Compare
henryde
force-pushed
the
feature/workspace
branch
from
98ccb7e to
23d3f3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.