Skip to content

Conversation

@pratikgitss
Copy link

@pratikgitss pratikgitss commented Dec 29, 2024

Description

This PR fixes meshery/meshery#13041, upgrading dominikh/staticcheck-action@v1 to dominikh/[email protected]

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@pratikgitss pratikgitss changed the title upgrade statichcheck-action to v1.3.0: Added proper sign-off upgrade statichcheck-action to v1.3.0: Dec 29, 2024
@pratikgitss pratikgitss changed the title upgrade statichcheck-action to v1.3.0: upgrade statichcheck-action to v1.3.0 Dec 29, 2024
@pratikgitss
Copy link
Author

@devhindo can you review this!

Copy link

@devhindo devhindo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devhindo
Copy link

yes, but in everywhere in the repo. there exist multiple setup-go actions

@pratikgitss
Copy link
Author

so i am required to change the setup-go actions wherever present in the repo, am i correct?

@pratikgitss pratikgitss reopened this Dec 29, 2024
@devhindo
Copy link

yes

@pratikgitss
Copy link
Author

I have made the changes as you said.

Copy link

@lekaf974 lekaf974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade statichcheck-action to v1.3.0 across all repos

3 participants