Skip to content

Fix/ignore list resources in crds #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix/ignore list resources in crds #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1313251
fix(manifests): skip CRDs with kind suffix 'List' during component ge…
Malka123456 Jul 23, 2025
fd555cc
update in openapi_generator.go to ignore somethingList
Malka123456 Jul 23, 2025
35e64e7
Update utils/manifests/generateComponent.go
Malka123456 Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions utils/component/openapi_generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,15 @@ func GenerateFromOpenAPI(resource string, pkg models.Package) ([]component.Compo
if err != nil {
continue
}

kind, err := kindCue.String()
if err != nil {
fmt.Printf("%v", err)
continue
}
if strings.HasSuffix(kind, "List") {
continue // Skip <resource>List types like PodList, DeploymentList, etc.
}

crd, err := fieldVal.MarshalJSON()
if err != nil {
Expand Down
13 changes: 13 additions & 0 deletions utils/manifests/generateComponent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package manifests

import (
"context"
"strings"

"cuelang.org/go/cue"
"cuelang.org/go/cue/cuecontext"
Expand Down Expand Up @@ -36,6 +37,18 @@ func GenerateComponents(ctx context.Context, manifest string, resource int, cfg
}
parsedCrd = cueCtx.BuildExpr(expr)
}
kindVal, err := cfg.CrdFilter.NameExtractor(parsedCrd)
if err == nil {
kindStr, strErr := kindVal.String()
if strErr != nil {
// TODO: Add logging for this error to aid debugging.
continue // skip if unable to convert to string
}
if strings.HasSuffix(kindStr, "List") {
continue // skip List kinds
}
}

outDef, err := getDefinitions(parsedCrd, resource, cfg, ctx)
if err != nil {
// inability to generate component for a single crd should not affect the rest
Expand Down