Skip to content

Conversation

abohoss
Copy link
Contributor

@abohoss abohoss commented Aug 11, 2025

Description

This PR fixes #784

Notes for Reviewers
Migrated OPA packages from v0 to v1
updated deprecated package in oci.go

Signed commits

  • Yes, I signed my commits.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @abohoss, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating and migrating several Go dependencies to their latest versions. The most notable changes involve upgrading the Open Policy Agent (OPA) package from v0 to v1, which required corresponding code adjustments for API compatibility, and updating a deprecated oras package version. These updates collectively aim to modernize the project's dependencies, reduce technical debt, and potentially enhance overall stability and performance.

Highlights

  • Open Policy Agent (OPA) Migration: The core Open Policy Agent (OPA) dependency has been upgraded from version 1.0.1 to 1.7.1. This significant update required refactoring the Rego policy evaluation logic in rego_policy_relationship.go to align with the new OPA v1 API, including changes to import paths and internal OPA interactions.
  • Oras Package Version Update: The oras.PackManifestVersion1_1_RC4 constant, which was deprecated, has been replaced with oras.PackManifestVersion1_1 in models/oci/oci.go. This updates the usage of the oras library to a current and supported version.
  • General Go Dependency Updates: Beyond the major OPA and Oras updates, this pull request includes a comprehensive refresh of numerous other Go module dependencies across the project. This ensures the codebase benefits from the latest features, bug fixes, and security patches provided by updated libraries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully updates several deprecated packages, most notably migrating the Open Policy Agent (OPA) package from v0 to v1. The refactoring in models/meshmodel/core/policies/rego_policy_relationship.go to accommodate the new OPA v1 API is well-executed, with significant improvements in error handling and logging that enhance the code's robustness. The dependency updates in go.mod and go.sum are comprehensive and align with the PR's objectives. The change in models/oci/oci.go also correctly addresses a deprecated constant. Overall, these are solid improvements to the codebase. I have one minor suggestion to further enhance code clarity.

@vr-varad
Copy link
Member

Thank you @abohoss for your contribution!!
If this work is complete, this is a good item to add to the weekly Meshery Development meeting agenda. You can add this item in the doc, attend, and present it. Meeting details at https://meet.layer5.io/meshery.

@n2h9
Copy link
Contributor

n2h9 commented Aug 23, 2025

Note, usage of RegoPolicyHandler in meshery:
https://github.com/search?q=org%3Ameshery+RegoPolicyHandler&type=code

signature is compatible ✅
meshery build with changes from this pr are passing ✅

Copy link
Contributor

@n2h9 n2h9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @abohoss ❤️

@n2h9 n2h9 merged commit 4191bc5 into meshery:master Aug 23, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting issues in multiple files
3 participants