feat: add SNR/RSSI/Hops Away metrics and timestamp to the reaction dialog #3964

1nv · 2025-12-10T23:58:22Z

Description

This change adds metrics to the reaction dialog, next to the emoji which a user reacted with. The metrics include 'Hops Away' for messages that went though hops or 'SNR/RSSI' for messages received directly – this is the same behavior you see with normal messages.

Below is the reaction dialog before:

and after:

Motivation

Our mesh network uses bots for testing connectivity. When a user sends a ping message to a specific channel, bots automatically reply with a message that includes 'Hops Away' or 'SNR/RSSI' values, so that the user could see which end-points received their message along with the aforementioned metrics on the way to those end-points. They can also see metrics on the way back in the message history.
To reduce clutter, I made a bot that sends a reaction with hop count (e.g. 1️⃣) or signal quality (e.g. 🟨 for fair quality). This way the user can still see the metrics towards my end-point, but no additional messages visible in channel are generated. However, they cannot see metrics on the way back, although they are technically available.
This change adds those missing metrics, at a cost of storing those within the database.
This can also be useful for networks without bots, as it can provide additional insights and the behavior is consistent with normal messages.

Additional Notes

I'm new to Kotlin, so I might have done something wrong. I have run Spotless and Detekt to check for errors.

…is useful for testing connectivity when users or bots react to a user's message.

CLAassistant · 2025-12-10T23:58:27Z

All committers have signed the CLA.

CLAassistant · 2025-12-10T23:58:27Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

…metrics

1nv · 2025-12-15T11:25:43Z

@jamesarich Hi, do I need to take further steps to mark this PR for review?

jamesarich · 2025-12-15T13:13:56Z

@jamesarich Hi, do I need to take further steps to mark this PR for review?

Just patience. We're volunteers and busy 😅

Copilot

Pull request overview

This PR adds SNR/RSSI and Hops Away metrics to the reaction dialog, providing users with signal quality information similar to what's shown for regular messages. The implementation includes database schema changes to store these metrics, UI updates to display them, and service logic refactoring to extract common hop calculation logic.

Key Changes:

Database schema upgraded to v24 with new columns (snr, rssi, hopsAway) added to the reactions table with appropriate default values
New getHopsAwayForPacket() helper function extracts duplicate hop calculation logic
Reaction dialog UI updated to display metrics conditionally based on signal data availability

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`core/database/schemas/org.meshtastic.core.database.MeshtasticDatabase/24.json`	New schema file defining reactions table with added metric columns (snr, rssi, hopsAway)
`core/database/src/main/kotlin/org/meshtastic/core/database/MeshtasticDatabase.kt`	Increments database version to 24 and adds AutoMigration entry
`core/database/src/main/kotlin/org/meshtastic/core/database/entity/Packet.kt`	Extends Reaction and ReactionEntity data classes with metric fields, updates mapping function
`app/src/main/java/com/geeksville/mesh/service/MeshService.kt`	Adds getHopsAwayForPacket() helper, refactors duplicate logic, populates metrics when storing reactions
`feature/messaging/src/main/kotlin/org/meshtastic/feature/messaging/component/Reaction.kt`	Updates ReactionDialog UI to display SNR/RSSI for direct messages or hops for relayed messages, adds preview data

app/src/main/java/com/geeksville/mesh/service/MeshService.kt

Copilot · 2025-12-15T13:34:54Z

feature/messaging/src/main/kotlin/org/meshtastic/feature/messaging/component/Reaction.kt

+                        if (reaction.snr != 0.0f) {
+                            if (reaction.hopsAway == 0) {
+                                Row(horizontalArrangement = Arrangement.spacedBy(8.dp)) {
+                                    Snr(reaction.snr)
+                                    Rssi(reaction.rssi)
+                                }
+                            } else {
+                                Text(
+                                    text = stringResource(Res.string.hops_away_template, reaction.hopsAway),
+                                    style = MaterialTheme.typography.labelSmall,
+                                )


When hopsAway is -1 (indicating invalid hop data per the logic in getHopsAwayForPacket), this will display "Hops Away: -1" to the user, which could be confusing. Consider checking if hopsAway is greater than 0 before showing hops, otherwise fall back to showing SNR/RSSI when snr is not 0. This would better match the user's expectation that -1 represents missing or invalid data rather than a meaningful hop count.

Suggested change

if (reaction.snr != 0.0f) {

if (reaction.hopsAway == 0) {

Row(horizontalArrangement = Arrangement.spacedBy(8.dp)) {

Snr(reaction.snr)

Rssi(reaction.rssi)

}

} else {

Text(

text = stringResource(Res.string.hops_away_template, reaction.hopsAway),

style = MaterialTheme.typography.labelSmall,

)

if (reaction.hopsAway > 0) {

Text(

text = stringResource(Res.string.hops_away_template, reaction.hopsAway),

style = MaterialTheme.typography.labelSmall,

)

} else if (reaction.snr != 0.0f) {

Row(horizontalArrangement = Arrangement.spacedBy(8.dp)) {

Snr(reaction.snr)

Rssi(reaction.rssi)

'Hops Away: -1' is consistent with normal message behavior.

jamesarich

Adding the field to the end of the row detracts from the primary usecase of this view - which is to view who sent the reaction. There is also more potential of overflow when screen sizes are small and fontsizes are large.

As this signal/hops information isn't necessary for the basic user and common usecases it needs to be very secondary and unobtrusive. Let's make each reaction list item two rows, moving the signal/hops info to the 2nd row - similar to how it is presented at the bottom of the message.

codecov · 2025-12-15T16:46:20Z

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.56%. Comparing base (8d858de) to head (ef68ada).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...in/java/com/geeksville/mesh/service/MeshService.kt	0.00%	9 Missing ⚠️
...meshtastic/feature/messaging/component/Reaction.kt	0.00%	7 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##            main   #3964      +/-   ##
========================================
- Coverage   0.56%   0.56%   -0.01%     
========================================
  Files        402     402              
  Lines      23884   23893       +9     
  Branches    3061    3061              
========================================
  Hits         136     136              
- Misses     23727   23736       +9     
  Partials      21      21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…me as for messages).

…s could be seen on the same screen after changes to two-row layout.

…metrics

1nv · 2025-12-16T14:00:00Z

@jamesarich I have updated the code for two-row layout, and added time string as well. I also slightly reduced spacing between entries, so that more could be seen on the same screen.

jamesarich

This seems a bit less obtrusive, and nice add of timestamp.

jamesarich · 2025-12-16T16:52:35Z

@1nv just wanted to say thanks again for the contribution 🤝.
If you're interested in contributing more regularly, feel free to reach out on discord - I'm @olm3c. We can get you better looped in to conversations and processes there ➰ .

1nv · 2025-12-16T17:13:16Z

@jamesarich Thank you for quick review and constructive feedback!

1nv · 2025-12-17T11:12:55Z

Small follow-up fix:
#4024

feat: add SNR/RSSI or Hops Away metrics to the reaction dialog. This …

3303d9f

…is useful for testing connectivity when users or bots react to a user's message.

1nv added 2 commits December 11, 2025 03:36

Merge branch 'main' into enhancement/reaction_metrics

5ebd75c

Merge remote-tracking branch 'origin/main' into enhancement/reaction_…

caf04a9

…metrics

jamesarich requested a review from Copilot December 15, 2025 13:15

Copilot started reviewing on behalf of jamesarich December 15, 2025 13:16 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

fix: typo in getHopsAwayForPacket()'s comment.

c4519f1

jamesarich requested changes Dec 15, 2025

View reviewed changes

1nv added 4 commits December 16, 2025 16:41

feat: layout SNR/RSSI/Hops values for each reaction into two rows (sa…

d788330

…me as for messages).

feat: show reaction time in reaction dialog (same as for messages).

99659c9

Reduce spacing between reaction entries to '4.dp' so that more entrie…

8fb9dd1

…s could be seen on the same screen after changes to two-row layout.

Merge remote-tracking branch 'origin/main' into enhancement/reaction_…

60207f6

…metrics

1nv requested a review from jamesarich December 16, 2025 14:00

fix: remove unused import and consts.

857d7b9

jamesarich approved these changes Dec 16, 2025

View reviewed changes

jamesarich enabled auto-merge December 16, 2025 14:38

1nv changed the title ~~feat: add SNR/RSSI or Hops Away metrics to the reaction dialog~~ feat: add SNR/RSSI/Hops Away metrics and timestamp to the reaction dialog Dec 16, 2025

jamesarich disabled auto-merge December 16, 2025 14:40

jamesarich added enhancement New feature or request ui Something to do with the UI of the Android app labels Dec 16, 2025

Merge branch 'main' into enhancement/reaction_metrics

ef68ada

jamesarich added this pull request to the merge queue Dec 16, 2025

Merged via the queue into meshtastic:main with commit 24f40b2 Dec 16, 2025
6 checks passed

jamesarich added this to the 2.7.10 milestone Dec 16, 2025

1nv mentioned this pull request Dec 17, 2025

fix: correctly check for local or pre-db-update reaction via RSSI == 0 #4024

Merged

Uh oh!

feat: add SNR/RSSI/Hops Away metrics and timestamp to the reaction dialog #3964

feat: add SNR/RSSI/Hops Away metrics and timestamp to the reaction dialog #3964

Uh oh!

Conversation

1nv commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation

Additional Notes

Uh oh!

CLAassistant commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Dec 10, 2025

Uh oh!

1nv commented Dec 15, 2025

Uh oh!

jamesarich commented Dec 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

1nv Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

jamesarich left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

1nv commented Dec 16, 2025

Uh oh!

jamesarich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jamesarich commented Dec 16, 2025

Uh oh!

1nv commented Dec 16, 2025

Uh oh!

1nv commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

1nv commented Dec 10, 2025 •

edited

Loading

CLAassistant commented Dec 10, 2025 •

edited

Loading

codecov bot commented Dec 15, 2025 •

edited

Loading