refactor(concurrent): Introduce SequentialJob to manage service setup #3983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a `SequentialJob` class to ensure that only one service setup operation runs at a time. The new class cancels any previous job before launching a new one. - Added `SequentialJob` class to manage a single, cancellable coroutine Job. - Refactored `MeshServiceClient` to use the injected `SequentialJob` for handling service connection and disconnection, simplifying its logic. - Added unit tests for `SequentialJob` to verify that it cancels previous jobs and can be cancelled itself. - Updated dependencies to include `kotlinx-coroutines-test` for testing. Signed-off-by: James Rich <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3983 +/- ##
========================================
+ Coverage 0.52% 0.58% +0.06%
========================================
Files 395 396 +1
Lines 23172 23182 +10
Branches 2944 2943 -1
========================================
+ Hits 122 136 +14
+ Misses 23029 23025 -4
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a
SequentialJobclass to ensure that only one service setup operation runs at a time. The new class cancels any previous job before launching a new one.SequentialJobclass to manage a single, cancellable coroutine Job.MeshServiceClientto use the injectedSequentialJobfor handling service connection and disconnection, simplifying its logic.SequentialJobto verify that it cancels previous jobs and can be cancelled itself.kotlinx-coroutines-testfor testing.