Skip to content

Conversation

@jamesarich
Copy link
Collaborator

Refactors the glow effect drawing logic within Modifier.drawWithCache. This change pre-calculates the radial gradient brush and applies the alpha dynamically, improving efficiency by avoiding brush recalculation on each animation step.

Refactors the glow effect drawing logic within `Modifier.drawWithCache`.
This change pre-calculates the radial gradient brush and applies the alpha dynamically, improving efficiency by avoiding brush recalculation on each animation step.
@jamesarich jamesarich enabled auto-merge December 12, 2025 21:47
@jamesarich jamesarich added this pull request to the merge queue Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.57%. Comparing base (22240a4) to head (5ea2020).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
app/src/main/java/com/geeksville/mesh/ui/Main.kt 0.00% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3988      +/-   ##
========================================
- Coverage   0.57%   0.57%   -0.01%     
========================================
  Files        401     401              
  Lines      23692   23696       +4     
  Branches    3041    3042       +1     
========================================
  Hits         136     136              
- Misses     23535   23539       +4     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit dded4f5 Dec 12, 2025
8 checks passed
@jamesarich jamesarich deleted the perf/glow branch December 12, 2025 22:20
@jamesarich jamesarich added this to the 2.7.10 milestone Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant