Skip to content

refactor: consolidate F-Droid task disabling to convention plugin #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesarich merged 1 commit into from
Dec 12, 2025
Merged

refactor: consolidate F-Droid task disabling to convention plugin #3990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,17 +259,6 @@ dependencies {
dokkaPlugin(libs.dokka.android.documentation.plugin)
}

val googleServiceKeywords = listOf("crashlytics", "google", "datadog")

tasks.configureEach {
if (
googleServiceKeywords.any { name.contains(it, ignoreCase = true) } && name.contains("fdroid", ignoreCase = true)
) {
project.logger.lifecycle("Disabling task for F-Droid: $name")
enabled = false
}
}

dokka {
moduleName.set("Meshtastic App")
dokkaSourceSets.main {
Expand Down
12 changes: 12 additions & 0 deletions build-logic/convention/src/main/kotlin/AnalyticsConventionPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,18 @@ class AnalyticsConventionPlugin : Plugin<Project> {
}
}
}

// Disable Analytics tasks for non-google flavors
val analyticsKeywords = listOf("crashlytics", "google", "datadog")
tasks.configureEach {
val taskName = name.lowercase()
val isAnalyticsTask = analyticsKeywords.any { taskName.contains(it) }

if (isAnalyticsTask && taskName.contains("fdroid")) {
logger.lifecycle("AnalyticsConventionPlugin: Disabling task $name")
enabled = false
}
}
}
}
}
11 changes: 0 additions & 11 deletions core/analytics/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,6 @@ dependencies {
googleApi(libs.firebase.crashlytics)
}

val googleServiceKeywords = listOf("crashlytics", "google", "datadog")

tasks.configureEach {
if (
googleServiceKeywords.any { name.contains(it, ignoreCase = true) } && name.contains("fdroid", ignoreCase = true)
) {
project.logger.lifecycle("Disabling task for F-Droid: $name")
enabled = false
}
}

android {
buildFeatures { buildConfig = true }
namespace = "org.meshtastic.core.analytics"
Expand Down