Skip to content

Conversation

@jamesarich
Copy link
Collaborator

@jamesarich jamesarich commented Dec 15, 2025

This commit introduces an "About" screen that displays a list of open-source libraries used in the app, leveraging the com.mikepenz:aboutlibraries library.

  • Added the "AboutLibraries" dependency and Gradle plugin.
  • Created AboutScreen.kt to display the list of licenses using LibrariesContainer.
  • Added a new navigation route SettingsRoutes.About.
  • Included a link to the new "About" screen within the main settings page.
    image image

This commit introduces an "About" screen that displays a list of open-source libraries used in the app, leveraging the `com.mikepenz:aboutlibraries` library.

- Added the "AboutLibraries" dependency and Gradle plugin.
- Created `AboutScreen.kt` to display the list of licenses using `LibrariesContainer`.
- Added a new navigation route `SettingsRoutes.About`.
- Included a link to the new "About" screen within the main settings page.

Signed-off-by: James Rich <[email protected]>
@github-actions github-actions bot added the enhancement New feature or request label Dec 15, 2025
This commit renames the "About" screen to "Acknowledgements" to more accurately reflect its content, which primarily displays open-source library information.

- Updated the title in `AboutScreen.kt` from "About" to "Acknowledgements".
- Changed the corresponding list item text in `SettingsScreen.kt`.
- Renamed the `about` string resource to `acknowledgements` in `strings.xml`.

Signed-off-by: James Rich <[email protected]>
…info

Configures the `aboutLibraries` plugin to fetch remote license and funding information for dependencies. This will provide more complete and up-to-date third-party library data.

Signed-off-by: James Rich <[email protected]>
This commit refactors the map feature's Gradle build script to use product flavors (`fdroid` and `google`) for managing map-related dependencies.

- `osmbonuspack` and `osmdroid-android` are now included only in the `fdroid` build flavor using `fdroidImplementation`.
- `play-services-location`, `maps-compose`, and `maps-compose-utils` were already correctly scoped to the `google` flavor.

This change isolates the OpenStreetMap dependencies from the Google Maps build, cleaning up the dependency graph for each flavor.

Signed-off-by: James Rich <[email protected]>
This commit improves the "About" screen by providing more detailed information for each open-source library used in the project. It also configures the `aboutLibraries` Gradle plugin to better handle duplicate library entries.

- Enabled the display of author, version, description, license badges, and funding badges in the libraries list.
- Configured the `aboutLibraries` plugin to merge duplicate library entries using a simple rule, cleaning up the generated data.

Signed-off-by: James Rich <[email protected]>
@jamesarich jamesarich marked this pull request as ready for review December 15, 2025 20:02
@jamesarich jamesarich enabled auto-merge December 15, 2025 20:02
Signed-off-by: James Rich <[email protected]>
@jamesarich jamesarich added this pull request to the merge queue Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.56%. Comparing base (40ba6ff) to head (3c81bdb).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...lin/org/meshtastic/feature/settings/AboutScreen.kt 0.00% 24 Missing ⚠️
.../org/meshtastic/feature/settings/SettingsScreen.kt 0.00% 6 Missing ⚠️
...m/geeksville/mesh/navigation/SettingsNavigation.kt 0.00% 1 Missing ⚠️
...in/kotlin/org/meshtastic/core/navigation/Routes.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #4012      +/-   ##
========================================
- Coverage   0.57%   0.56%   -0.01%     
========================================
  Files        401     402       +1     
  Lines      23852   23884      +32     
  Branches    3060    3061       +1     
========================================
  Hits         136     136              
- Misses     23695   23727      +32     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 9804c38 Dec 15, 2025
6 checks passed
@jamesarich jamesarich deleted the feat/aboutlibraries branch December 15, 2025 21:14
@jamesarich jamesarich added this to the 2.7.10 milestone Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant