-
-
Notifications
You must be signed in to change notification settings - Fork 390
feat(settings): add about screen with open source licenses #4012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces an "About" screen that displays a list of open-source libraries used in the app, leveraging the `com.mikepenz:aboutlibraries` library. - Added the "AboutLibraries" dependency and Gradle plugin. - Created `AboutScreen.kt` to display the list of licenses using `LibrariesContainer`. - Added a new navigation route `SettingsRoutes.About`. - Included a link to the new "About" screen within the main settings page. Signed-off-by: James Rich <[email protected]>
This commit renames the "About" screen to "Acknowledgements" to more accurately reflect its content, which primarily displays open-source library information. - Updated the title in `AboutScreen.kt` from "About" to "Acknowledgements". - Changed the corresponding list item text in `SettingsScreen.kt`. - Renamed the `about` string resource to `acknowledgements` in `strings.xml`. Signed-off-by: James Rich <[email protected]>
…info Configures the `aboutLibraries` plugin to fetch remote license and funding information for dependencies. This will provide more complete and up-to-date third-party library data. Signed-off-by: James Rich <[email protected]>
This commit refactors the map feature's Gradle build script to use product flavors (`fdroid` and `google`) for managing map-related dependencies. - `osmbonuspack` and `osmdroid-android` are now included only in the `fdroid` build flavor using `fdroidImplementation`. - `play-services-location`, `maps-compose`, and `maps-compose-utils` were already correctly scoped to the `google` flavor. This change isolates the OpenStreetMap dependencies from the Google Maps build, cleaning up the dependency graph for each flavor. Signed-off-by: James Rich <[email protected]>
This commit improves the "About" screen by providing more detailed information for each open-source library used in the project. It also configures the `aboutLibraries` Gradle plugin to better handle duplicate library entries. - Enabled the display of author, version, description, license badges, and funding badges in the libraries list. - Configured the `aboutLibraries` plugin to merge duplicate library entries using a simple rule, cleaning up the generated data. Signed-off-by: James Rich <[email protected]>
Signed-off-by: James Rich <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4012 +/- ##
========================================
- Coverage 0.57% 0.56% -0.01%
========================================
Files 401 402 +1
Lines 23852 23884 +32
Branches 3060 3061 +1
========================================
Hits 136 136
- Misses 23695 23727 +32
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces an "About" screen that displays a list of open-source libraries used in the app, leveraging the
com.mikepenz:aboutlibrarieslibrary.AboutScreen.ktto display the list of licenses usingLibrariesContainer.SettingsRoutes.About.