refactor: Migrate from Protobuf-Java to Wire #4246
Draft
+4,917
−4,398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit migrates the project from using the `protobuf-java` library to `wire`. This involves extensive changes across the codebase to adapt to the new generated models and their APIs. Key changes include: - Replaced Protobuf builders with Wire's immutable data classes and `copy()` method. - Updated field access from camelCase (`longName`) to snake_case (`long_name`). - Switched from `com.google.protobuf.ByteString` to `okio.ByteString`. - Replaced Protobuf's `hasField()` checks with null checks on Wire's optional fields. - Adapted `enum` handling to work with Wire-generated enums, removing "UNRECOGNIZED" filters. - Removed Protobuf-specific utility code, such as `userFieldsToString` and `compareUsers` which relied on Descriptors. - Updated Gradle build scripts (`build.gradle.kts`, `libs.versions.toml`) to remove Protobuf dependencies and add Wire dependencies and the Wire plugin. - Updated ProGuard rules to keep Wire-generated classes. Signed-off-by: James Rich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates the project from using the
protobuf-javalibrary towire. This involves extensive changes across the codebase to adapt to the new generated models and their APIs.Key changes include:
copy()method.longName) to snake_case (long_name).com.google.protobuf.ByteStringtookio.ByteString.hasField()checks with null checks on Wire's optional fields.enumhandling to work with Wire-generated enums, removing "UNRECOGNIZED" filters.userFieldsToStringandcompareUserswhich relied on Descriptors.build.gradle.kts,libs.versions.toml) to remove Protobuf dependencies and add Wire dependencies and the Wire plugin.