Nz region sf16 preset - #11009
Open
NomDeTom wants to merge 13 commits into
Open
Conversation
New Zealand's mesh standard is ShortFast on frequency slot 16, which lands on 918.875 MHz in the 915-928 MHz ANZ band. Set the region's default preset to SHORT_FAST and pin the default frequency slot with an explicit overrideSlot of 16 instead of the channel-name hash. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ToW4ouBGLnJEo6wQDobdJc
Revert the ANZ region-table change: ANZ is shared with Australia (and
historically Brazil), so changing its default preset there would alter
defaults for everyone, not just New Zealand.
Instead, bake the NZ community defaults into firmware built from this
repo via userPrefs.jsonc: region ANZ and modem preset SHORT_FAST. No
frequency-slot override is needed - the default channel name
("ShortFast") hashes to slot 16, which is 918.875 MHz, the NZ mesh
standard.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ToW4ouBGLnJEo6wQDobdJc
Co-authored-by: NomDeTom <116762865+NomDeTom@users.noreply.github.com>
.gitmodules now tracks NomDeTom/MeshtasticProtobufs @ nz-sf, rebased onto upstream meshtastic/protobufs master (adds NZ_924 as a new RegionCode value, additive/non-breaking). Regenerated the nanopb C sources from that commit, which also incidentally picks up the MEDIUM_TURBO modem preset added upstream in the same rebase window. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ToW4ouBGLnJEo6wQDobdJc
Same 915-928 MHz band and PROFILE_STD as ANZ, but defaults to SHORT_FAST instead of LONG_FAST. Frequency slot is left on the default channel-name hash (overrideSlot 0), which for the "ShortFast" channel name lands on slot 16 = 918.875 MHz, the New Zealand mesh standard. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ToW4ouBGLnJEo6wQDobdJc
NomDeTom
added
enhancement
Contributor
⚡ Try this PR in the Web Flasher
Warning This is an automated, unreviewed CI test build. Back up your device configuration Supported boards built by this PR (27)
Build artifacts expire on 2026-08-13. Updated for |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (6)
📝 WalkthroughWalkthroughThe protobufs source and pinned commit are updated. The radio region table adds ChangesNew Zealand regional support
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant RegionPicker
participant MenuApplet
participant RadioInterface
RegionPicker->>MenuApplet: select NZ_915 menu entry
MenuApplet->>RadioInterface: applyLoRaRegion(NZ_915)
RadioInterface-->>MenuApplet: apply NZ_915 configuration
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: NomDeTom <116762865+NomDeTom@users.noreply.github.com>
8 tasks
8 tasks
# Conflicts: # protobufs # src/mesh/generated/meshtastic/interdevice.pb.cpp # src/mesh/generated/meshtastic/interdevice.pb.h
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new region to allow the ShortFast preset to be the default in New Zealand from the start, rather than LongFast as is the default for the ANZ region.
Requires protobufs: meshtastic/protobufs#985
🤝 Attestations
Summary by CodeRabbit
New Features
Improvements