fix(misc): Fix few compilation/check warnings #8502
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaositek
requested changes
Oct 31, 2025
Contributor
Xaositek
left a comment
Xaositek
left a comment
There was a problem hiding this comment.
This moves around a lot of code just for the sake of moving things around. Too many things are blindly moved without consideration in BaseUI for me to be comfortable with it. I do not agree.
Contributor
|
Some of this is also available already in #8182 |
Contributor
|
most of these changes are already addressed on #8182 which redesigns a huge chunk of the code already. I'd suggest only merging this after that PR is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes to eliminate compiler warnings, mainly removing dead code.
🤝 Attestations
Tested on Heltec Wireless Paper (ESP32S3)