Skip to content

CLIENT_BASE: Act like ROUTER_LATE for fav'd nodes, instead of like ROUTER #8567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+3 −5
Open

CLIENT_BASE: Act like ROUTER_LATE for fav'd nodes, instead of like ROUTER #8567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22b4f3f
Client_Base - Dont rebroadcast in early (Router) window
korbinianbauer Nov 6, 2025
259082c
Client_Base - Clamp rebroadcast to late (Router_Late) window on dupe
korbinianbauer Nov 6, 2025
1eae961
Merge branch 'meshtastic:develop' into late_window_client_base
korbinianbauer Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/mesh/FloodingRouter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ void FloodingRouter::perhapsCancelDupe(const meshtastic_MeshPacket *p)
if (config.device.role == meshtastic_Config_DeviceConfig_Role_ROUTER_LATE && iface) {
iface->clampToLateRebroadcastWindow(getFrom(p), p->id);
}
if (config.device.role == meshtastic_Config_DeviceConfig_Role_CLIENT_BASE && iface) {
Copy link
Member

@GUVWAF GUVWAF Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also check for isFromOrToFavoritedNode() here then.

iface->clampToLateRebroadcastWindow(getFrom(p), p->id);
}
}

bool FloodingRouter::isRebroadcaster()
Expand Down
5 changes: 0 additions & 5 deletions src/mesh/RadioInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,11 +296,6 @@ bool RadioInterface::shouldRebroadcastEarlyLikeRouter(meshtastic_MeshPacket *p)
return true;
}

// If we are a CLIENT_BASE and the packet is from or to a favorited node, we should rebroadcast early
if (config.device.role == meshtastic_Config_DeviceConfig_Role_CLIENT_BASE) {
return nodeDB->isFromOrToFavoritedNode(*p);
}

return false;
}

Expand Down