-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Lora settings expansion and validation logic improvement #9878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thebentern
merged 44 commits into
meshtastic:develop
from
NomDeTom:radio_interface_cherrypick
Mar 20, 2026
+1,350
−247
Merged
Changes from 29 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
fe1f5d9
Enhance LoRa configuration with modem presets and validation logic
NomDeTom 3ff2c3b
Rename bootstrapLoRaConfigFromPreset tests to validateModemConfig for…
NomDeTom 9f1a824
Merge branch 'meshtastic:develop' into radio_interface_cherrypick
NomDeTom feb5172
additional tidy-ups to the validateModemConfig - still fundamentally …
NomDeTom e71e6a9
Enhance region validation by adding numPresets to RegionInfo and impl…
NomDeTom 36a8215
Add validation for modem configuration in applyModemConfig
NomDeTom 0254105
Fix region unset handling and improve modem config validation in hand…
NomDeTom 5259494
Refactor LoRa configuration validation methods and introduce clamping…
NomDeTom cf9712e
Update handleSetConfig to use fromOthers parameter to either correct …
NomDeTom eb240d7
Merge branch 'develop' into radio_interface_cherrypick
NomDeTom 237ac2c
Fix some of the copilot review comments for LoRa configuration valida…
NomDeTom 0ada155
Redid the slot default checking and calculation. Should resolve the o…
NomDeTom 4a5da3e
Add bandwidth calculation for LoRa modem preset fallback in clampConf…
NomDeTom ef72c40
Remove unused preset name variable in validateConfigLora and fix defa…
NomDeTom 2e84995
update tests for region handling
NomDeTom 251b64f
Merge branch 'develop' into radio_interface_cherrypick
NomDeTom b6d55af
Got the synthetic colleague to add mock service for testing
NomDeTom c73b592
Flash savings... hopefully
NomDeTom ca28017
Refactor modem preset handling to use sentinel values and improve def…
NomDeTom 3c3ddde
Refactor region handling to use profile structures for modem presets …
NomDeTom d768507
added comments for clarity on parameters
NomDeTom a9bc5ce
Add shadow table tests and validateConfigLora enhancements for region…
NomDeTom e14a6a5
Merge branch 'meshtastic:develop' into radio_interface_cherrypick
NomDeTom e475562
Add isFromUs tests for preset validation in AdminModule
NomDeTom d554c82
Merge branch 'meshtastic:develop' into radio_interface_cherrypick
NomDeTom e3d5b49
Respond to copilot github review
NomDeTom 4c28a6b
Merge branch 'develop' into radio_interface_cherrypick
NomDeTom b4ca217
address copilot comments
NomDeTom f9ea6be
address null poointers
NomDeTom f5e959d
fix build errors
NomDeTom b471666
Fix the fix, undo the silly suggestions from synthetic reviewer.
NomDeTom eca8218
we all float here
NomDeTom dbedf27
Fix include path for AdminModule in test_main.cpp
NomDeTom c31c904
Potential fix for pull request finding
NomDeTom dfc38fc
More suggestion fixes
NomDeTom ca74713
Merge branch 'develop' into radio_interface_cherrypick
NomDeTom 1d9d6bb
admin module merge conflicts
NomDeTom 78d8802
admin module fixes from merge hell
NomDeTom d060e0d
Merge branch 'develop' into radio_interface_cherrypick
NomDeTom 107191b
fix: initialize default frequency slot and custom channel name; updat…
NomDeTom f1a56bc
save some bytes...
NomDeTom 7ef568b
Merge branch 'develop' into radio_interface_cherrypick
NomDeTom 2ee48b7
fix: simplify error logging for bandwidth checks in LoRa configuration
NomDeTom 3cba534
Update src/mesh/MeshRadio.h
NomDeTom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule protobufs
updated
4 files
| +0 −12 | meshtastic/admin.proto | |
| +0 −5 | meshtastic/mesh.proto | |
| +0 −13 | meshtastic/portnums.proto | |
| +4 −9 | meshtastic/telemetry.proto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.