Heltec v4.3: enable LNA by default#9906
Conversation
|
Wessel Nieboer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
8bbb621 to
a62feea
Compare
a62feea to
08e6792
Compare
|
Thanks! Can we get a few v4 users to share their results? Code seems fine, just feels like we're flipping back and forth a little on this device. |
Fairly certain ON is the way to go by default. FYI, Heltec v4.2 and earlier didn't have a way to turn off the low noise amplifier at all. It was always physically in the RX path. Heltec v4.3 came out with the main purpose being for users to able to bypass the LNA without doing a hardware bypass mod. Realistically you'd only want to disable it if you have problematic RF interference. |
08e6792 to
85fa380
Compare
|
I'm Alien here, but maybe it can be an option to choose in web flasher for v4 like "Choose version you have 4.1\4.2 or 4.3" ? |
Not needed. All versions are supported by the firmware. 4.2 and earlier didn't have an LNA you could toggle on/off with software so the configuration does not apply there. It's only relevant to 4.3+ |
85fa380 to
ce37a6e
Compare
It should only be disabled by users that have problems with it.
a9a9c1a to
e0c6abb
Compare
It should only be disabled by users that have problems with it.
It should only be disabled by users that have problems with it. Anyone using Heltec v4.3 and not setting it explicitly will have bad RX.
Get firmware here: