Skip to content

Fix TFTDisplay::display for General DMA#9956

Open
notmasteryet wants to merge 1 commit intomeshtastic:developfrom
notmasteryet:fix-gdma
Open

Fix TFTDisplay::display for General DMA#9956
notmasteryet wants to merge 1 commit intomeshtastic:developfrom
notmasteryet:fix-gdma

Conversation

@notmasteryet
Copy link
Contributor

The device, such as esp32c6, require 32-bit alignment for the data.

The patch aligns start and end of the update pixels buffer. In worst case, it will add two extra pixels per row.

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)
    • Private hardware based on esp32c6 with 1.47" LCD

@github-actions github-actions bot added needs-review Needs human review hardware-support Hardware related: new devices or modules, problems specific to hardware labels Mar 19, 2026
The device, such as esp32c6, require 32-bit alignment for the data.

The patch aligns start and end of the update pixels buffer.
@notmasteryet
Copy link
Contributor Author

The alternative is just start filling linePixelBuffer from start, but we need to maintain separate index for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hardware-support Hardware related: new devices or modules, problems specific to hardware needs-review Needs human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant