Optimize performance for animations.#316
Open
Lwrless wants to merge 2 commits intomeshtastic:mainfrom
Open
Conversation
…light mode (too subtle to display).
|
|
|
@Lwrless is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes animation performance by reducing CPU usage through improved animation handling and CSS optimizations. The changes focus on minimizing unnecessary style recalculations and improving rendering efficiency.
Changes:
- Replaced pseudo-element animations with dedicated elements to reduce style recalculation overhead
- Introduced hover-based animation control to conditionally enable animations only when needed
- Added explicit type annotations and improved code structure for better maintainability
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| types/resources.ts | Added explicit type annotation to vendorCobrandingTag |
| tailwind.config.js | Added new bounce-in-place animation keyframe for optimized bouncing effect |
| components/LogoHeader.vue | Refactored glow animation from pseudo-element to dedicated element with performance optimizations |
| components/Firmware.vue | Improved code structure with better indentation, added missing keys to v-for loops, and strengthened type safety |
| components/Device.vue | Added hover state management and conditional animation triggering, improved modal layout structure |
| app.vue | Connected hover state to Device component, cleaned up formatting and code style |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Testing
Hello! Thanks for maintaining this project. While using the flasher site to flash my Meshtastic devices, I noticed a couple of minor issues and put together some improvements.
This PR: