BUG: allow install_subdir() of missing directories #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the assert that made sure the source path for install_subdir() is an existing directory. Meson warns in this case but allows it. Empty directories for missing source directories are not created in the Python wheel as these are hardly meaningful.
|
Replaces #675 |
rgommers
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Seems reasonable to do nothing"instead of erroring out, given the discussion in gh-675.
Meson does display a deprecation warning in the build log like:
WARNING: Deprecated features used:
* 0.60.0: {'install_subdir with empty directory'}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the assert that made sure the source path for install_subdir() is an existing directory. Meson warns in this case but allows it. Empty directories for missing source directories are not created in the Python wheel as these are hardly meaningful.