Skip to content

CI: pyproject-metadata 0.9.0 has been released, no need to test rc #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

CI: pyproject-metadata 0.9.0 has been released, no need to test rc #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd84827
CI: pyproject-metadata 0.9.0 has been released, no need to test rc
dnicolodi Oct 23, 2024
3eb11b0
MAINT: fixes to comply with pyproject-metadata 0.9.0 type annotations
dnicolodi Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,6 @@ jobs:
- os: ubuntu-latest
python: '3.12'
pyproject_metadata: '==0.8.0'
# Tets with pyproject-metadata release candidate
- os: ubuntu-latest
python: '3.12'
pyproject_metadata: '==0.9.0rc1'

steps:
- name: Checkout
Expand Down
4 changes: 2 additions & 2 deletions mesonpy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def __init__(self, name: str, *args: Any, **kwargs: Any):
super().__init__(name, *args, **kwargs)

@classmethod
def from_pyproject(
def from_pyproject( # type: ignore[override]
cls,
data: Mapping[str, Any],
project_dir: Path = os.path.curdir,
Expand Down Expand Up @@ -345,7 +345,7 @@ def _libs_dir(self) -> str:
@property
def _license_file(self) -> Optional[pathlib.Path]:
license_ = self._metadata.license
if license_:
if license_ and isinstance(license_, pyproject_metadata.License):
return license_.file
return None

Expand Down
Loading