Skip to content

Conversation

@dnicolodi
Copy link
Member

No description provided.

@rgommers rgommers added documentation Improvements or additions to documentation maintenance Regular code improvements that are not new features nor end-user-visible bugs labels May 2, 2025
@rgommers rgommers added this to the v0.18.0 milestone May 2, 2025
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor textual tweak.

I looked through the other issues and PRs - seems like all that can wait, and we can release 0.18.0 today. Can you confirm @dnicolodi? I have some time to do the release later today.

@dnicolodi
Copy link
Member Author

The macOS test failure is due to Meson bug mesonbuild/meson#14534 and Cirrus got stock trying to run the fedora-41 job...

@dnicolodi
Copy link
Member Author

Including #728 in the releases would enable matplotlib to remove a meson-python version pin to 0.16.2. IIRC you already reviewed #728 and the only thing missing were warnings, which I added. However, it is not a must for releasing 0.18.0

@rgommers
Copy link
Contributor

rgommers commented May 2, 2025

I'd be inclined to do 0.18.0 right now, and a next 0.19.0 feature release as soon as #728 (and probably #731) is in. #728 is still actively being discussed, so I hesitate to hit the merge button there now. And it'd be nice to get the release out and test the PEP 639 waters.

@dnicolodi
Copy link
Member Author

The discussion in #728 has nothing to do with the changes in #728 and it stems from a misunderstanding of what the PR does.

@rgommers
Copy link
Contributor

rgommers commented May 2, 2025

Okay, let me have another look at #728 now then.

@rgommers
Copy link
Contributor

rgommers commented May 2, 2025

Merged #728 now. Do you want to add a Changelog entry for it?

@rgommers
Copy link
Contributor

rgommers commented May 3, 2025

I'll do it now actually and then merge, so I can get the release out today.

@rgommers rgommers merged commit 965c472 into mesonbuild:main May 3, 2025
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation maintenance Regular code improvements that are not new features nor end-user-visible bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants