TST: rework the sharedlib-in-package test package #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
force-pushed
the
rpath-tests
branch
13 times, most recently
from
0460133 to
556faac
Compare
This entries are not meaningful. This has the additional benefit of not returning an empty string RPATH entry for binaries with RPATH unset.
This reorganizes the test package to a flatter layout that helps visualizing all the parts involved in the test and introduces an asymmetry between the source layout and the installation layout that demonstrates the bugs in the RPATH handling.
meson-python does not support `install_rpath` yet and anyhow `install_rpath` is not exposed in the introspection data and thus cannot be set by meson-python when building the Python wheel. Use `link_args` to set the RPATH.
macOS requires using `@loader_path` in place of `$ORIGIN`.
This shows that build RPATHs are not correctly stripped.
|
@rgommers This PR reworks some of the tests involving RPATH entries and adds more to demonstrate the shortcoming of the current implementation. All tests are made to pass but contain comments on the observed wrong behaviors. Next I'll split the RPATH handling patch into smaller pieces easier to review. |
|
@rgommers This only adds or reworks tests. I'll merge it soon and start to work on fixing the issues identified by these tests, unless you see issues with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reorganizes the test package to a flatter layout that helps visualizing all the parts involved in the test and introduces an asymmetry between the source layout and the installation layout that demonstrates the bugs in the RPATH handling.