Skip to content

Conversation

@dnicolodi
Copy link
Member

No description provided.

@dnicolodi dnicolodi force-pushed the dependency-groups branch 4 times, most recently from 630a92b to 3a9f2c9 Compare October 18, 2025 22:49
@dnicolodi
Copy link
Member Author

Dependency groups are supported starting with pip 25.1 which dropped support for Python 3.8, thus this will have to wait till we drop support for Python 3.8 or start using uv to manage the test environments.

@dnicolodi dnicolodi marked this pull request as draft October 18, 2025 22:59
@rgommers
Copy link
Contributor

Python 3.8 has been EOL for over a year, and Python 3.9 is also EOL now (see https://devguide.python.org/versions/). So I think dropping 3.8 now is perfectly fine.

@dnicolodi dnicolodi force-pushed the dependency-groups branch 2 times, most recently from ea67779 to 076563b Compare October 19, 2025 15:36
@dnicolodi dnicolodi changed the title MAINT: switch from extra dependencies to dependency groups Drop Python 3.8 from CI and switch from extra dependencies to dependency groups Oct 19, 2025
@dnicolodi dnicolodi marked this pull request as ready for review October 19, 2025 16:06
@dnicolodi
Copy link
Member Author

@rgommers I opted for dropping Python 3.8 from the CI jobs but not bump the required Python version. Should we bump requires-python to >= 3.9?

@rgommers
Copy link
Contributor

Should we bump requires-python to >= 3.9?

I think so, yes. 3.8 support will not go anywhere for 0.18.0, and almost no one needs it anymore so I doubt future bug fixes are going to matter. So if we're dropping CI jobs, bumping requires-python is preferred imho.

@eli-schwartz
Copy link
Member

I think so, yes. 3.8 support will not go anywhere for 0.18.0, and almost no one needs it anymore so I doubt future bug fixes are going to matter. So if we're dropping CI jobs, bumping requires-python is preferred imho.

👍 to explicitly "breaking it" if you decline to test it. Meson does support 3.7 though I suppose most meson-python users are less concerned about backporting to LTS distros.

@rgommers
Copy link
Contributor

though I suppose most meson-python users are less concerned about backporting to LTS distros.

Indeed. We have never had a case of a bug fix in the latest release being critical for an LTS distro for a Python version we dropped. In the quite unlikely case it does happen, it can be dealt with then by the distro applying a patch or by a new 0.18.1 bug fix release.

@dnicolodi dnicolodi changed the title Drop Python 3.8 from CI and switch from extra dependencies to dependency groups Bump requirede Python version to 3.9 and switch from extra dependencies to dependency groups Oct 19, 2025
@rgommers rgommers changed the title Bump requirede Python version to 3.9 and switch from extra dependencies to dependency groups Bump required Python version to 3.9 and switch from extra dependencies to dependency groups Oct 23, 2025
@rgommers rgommers added the maintenance Regular code improvements that are not new features nor end-user-visible bugs label Oct 23, 2025
@rgommers rgommers added this to the v0.19.0 milestone Oct 23, 2025
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM, in it goes.

@rgommers rgommers merged commit 09e18fc into mesonbuild:main Oct 23, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Regular code improvements that are not new features nor end-user-visible bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants