-
Notifications
You must be signed in to change notification settings - Fork 82
CI: setup release artifacts build job and upload with trusted publishing #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CI: setup release artifacts build job and upload with trusted publishing #819
Conversation
d182e09 to
721d71e
Compare
|
I just finished implementing this, as I said I would a few days ago in #710 (comment) |
|
It's essentially the same: main...rgommers:meson-python:use-trusted-publishing. Differences:
Feel free to merge them. Yours has a nicer pattern for |
|
Sorry. This is basically copy and paste from another project of mines thus it took very little to put together. I agree that running on PRs is a good idea. I'd look at the other differences. |
|
No worries. The only other thing I suggest is to name the deployment env |
3dca6bf to
13e3c62
Compare
13e3c62 to
331f4b6
Compare
| runs-on: ubuntu-latest | ||
| if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags') | ||
| environment: | ||
| name: pipy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: should be pypi.
|
@dnicolodi I missed your last push, you did address my one remaining comment. Shall we merge this (after fixing the typo) and wire it up before doing the 0.19.0 release? |
No description provided.