Skip to content

Conversation

stoeckmann
Copy link
Contributor

@stoeckmann stoeckmann commented Oct 4, 2025

Take the key/value separator = into account when comparing long and short option names to avoid invalid matches.

Proof of Concept, run in top directory of checked out meson project:

./meson.py -Dunity=on --unity-size=4

Before this pull request, the output is:

Got argument unity as both -Dunity= and --unity. Pick one.

After this pull request, the output is:

ERROR: Must specify at least one directory name.
WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.

@stoeckmann stoeckmann requested a review from jpakkane as a code owner October 4, 2025 09:30
@bonzini bonzini added this to the 1.10 milestone Oct 4, 2025
@bonzini bonzini added bug options Meson configuration options labels Oct 4, 2025
@jpakkane
Copy link
Member

jpakkane commented Oct 4, 2025

This needs a test.

@stoeckmann
Copy link
Contributor Author

I have added a unit test.

Take the key/value separator `=` into account when comparing long and
short option names to avoid invalid matches.
@bonzini bonzini modified the milestones: 1.10, 1.9.2 Oct 15, 2025
@jpakkane jpakkane merged commit 7b4c799 into mesonbuild:master Oct 17, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug options Meson configuration options

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants