fix rustc -l argument on Windows #15100
Merged
+29
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzini
force-pushed
the
rustc-windows-lib
branch
4 times, most recently
from
ccaecfd to
9710afa
Compare
The variable for the .a here is called "a", not "lib". Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
force-pushed
the
rustc-windows-lib
branch
from
9710afa to
e38d52d
Compare
On Windows, rustc searches both FOO.lib and libFOO.a when passed -lfoo. This means that the check for nonstandard names in the Unix sense is too struct, and indeed it breaks passing for example -lkernel32 (which adds kernel32.lib to the link). Fix this by special casing Windows. Extract the logic to the Rust compiler class for clarity. Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
force-pushed
the
rustc-windows-lib
branch
from
e38d52d to
5f83e44
Compare
dcbaker
approved these changes
Oct 10, 2025
|
I see it's already merged, but I was going to give me +1 too. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, rustc searches both FOO.lib and libFOO.a when passed -lfoo. This means that the check for nonstandard names is too struct, and indeed it breaks passing for example -lkernel32 (which adds kernel32.lib to the link).
Fix this by special casing Windows. Extract the logic to the Rust compiler class for clarity.
This fixes a semantic conflict between PRs #14991 and #15024.